From: Karel Zak <kzak@redhat.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: "Maciej Małecki" <me@mmalecki.com>,
"Davidlohr Bueso" <davidlohr@hp.com>,
util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] fdisk: warn if opening a device in write mode failed
Date: Fri, 21 Mar 2014 14:10:03 +0100 [thread overview]
Message-ID: <20140321131003.GF26374@x2.net.home> (raw)
In-Reply-To: <5310B80C.7000205@ubuntu.com>
On Fri, Feb 28, 2014 at 11:23:40AM -0500, Phillip Susi wrote:
> You really want to tell the user that they aren't going to be able to
> write up front.
>
> I have to say this function was already broken. If the caller
> requests write access and that fails, then the call should fail. It
> should *not* automatically fall back to read-only without giving any
> indication to the caller. If the caller wants to retry for read only,
> then it can, and print a warning letting the user know it has switched
> to ready only.
I agree, implemented. The function does not fallback to read-only mode
now -- all has to be controlled by caller.
Thanks Maciej for your report!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-03-21 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 3:26 [PATCH 1/2] fdisk: warn if opening a device in write mode failed Maciej Małecki
2014-02-27 3:26 ` [PATCH 2/2] fdisk: do not allow writing to a read-only device Maciej Małecki
2014-02-28 2:32 ` [PATCH 1/2] fdisk: warn if opening a device in write mode failed Davidlohr Bueso
2014-02-28 11:00 ` Maciej Małecki
2014-02-28 16:23 ` Phillip Susi
2014-02-28 18:18 ` Maciej Małecki
2014-02-28 18:27 ` Davidlohr Bueso
2014-02-28 19:18 ` Phillip Susi
2014-03-03 9:04 ` Karel Zak
2014-03-03 21:19 ` Maciej Małecki
2014-03-03 21:47 ` Phillip Susi
2014-03-21 13:10 ` Karel Zak [this message]
2014-03-03 21:14 ` [PATCH v2 1/3] fdisk: do not allow writing to a read-only device Maciej Małecki
2014-03-03 21:14 ` [PATCH v2 2/3] libfdisk: remove `O_RDONLY` fallback mode when opening device Maciej Małecki
2014-03-03 21:14 ` [PATCH v2 3/3] fdisk: retry opening device in read-only mode Maciej Małecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321131003.GF26374@x2.net.home \
--to=kzak@redhat.com \
--cc=davidlohr@hp.com \
--cc=me@mmalecki.com \
--cc=psusi@ubuntu.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox