[PATCH] blockdev(8): Some minor corrections to the manual

[PATCH] blockdev(8): Some minor corrections to the manual

[Bjarni Ingi Gislason]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Package: util-linux
Version: 2.24.1
Severity: minor
File: disk-utils/blockdev.8
Tags: patch

  Changes:

  Macro, that alternately changes the input between two font styles,
changed to the macro for one font style change, if there is only one
argument

 Text string, that begins or ends with a full stop (.) protected with \&

 -- changed to \-\- if it is an option

 - changed to \(en if it is a dash (pause, seperation)

  Patch is in the attachment

-- 
Bjarni I. Gislason

[-- Attachment #2: blockdev.8.diff --]
[-- Type: text/plain, Size: 1814 bytes --]

--- blockdev.8	2013-10-15 10:50:43.000000000 +0000
+++ blockdev.8.new	2014-04-01 19:15:33.000000000 +0000
@@ -10,14 +10,14 @@ blockdev \- call block device ioctls fro
 .B blockdev
 .RB [ \-q ]
 .RB [ \-v ]
-.IR command
-.RI [ command ...]
-.IR device
-.RI [ device ...]
+.I command
+.RI [ command \&...\&]
+.I device
+.RI [ device \&...\&]
 .br
 .B blockdev
 .B \-\-report
-.RI [ device ...]
+.RI [ device \&...\&]
 .SH DESCRIPTION
 The utility
 .B blockdev
@@ -60,9 +60,9 @@ Get read-only. Print 1 if the device is
 .IP "\fB\-\-getsize64\fP"
 Print device size in bytes.
 .IP "\fB\-\-getsize\fP"
-Print device size (32-bit!) in sectors. Deprecated in favor of the --getsz option.
+Print device size (32-bit!) in sectors. Deprecated in favor of the \-\-getsz option.
 .IP "\fB\-\-getss\fP"
-Print sectorsize in bytes - usually 512.
+Print sectorsize in bytes \(en usually 512.
 .IP "\fB\-\-getsz\fP"
 Get size in 512-byte sectors.
 .IP "\fB\-\-rereadpt\fP"
@@ -72,7 +72,7 @@ Set blocksize. Note that the block size
 descriptor opening the block device, so the change of block size only persists
 for as long as blockdev has the device open, and is lost once blockdev exits.
 .IP "\fB\-\-setfra\fP \fIsectors\fP"
-Set filesystem readahead (same like --setra on 2.6 kernels).
+Set filesystem readahead (same like \-\-setra on 2.6 kernels).
 .IP "\fB\-\-setra\fP \fIsectors\fP"
 Set readahead (in 512-byte sectors).
 .IP "\fB\-\-setro\fP"
@@ -80,7 +80,7 @@ Set read-only.
 .IP "\fB\-\-setrw\fP"
 Set read-write.
 .SH AUTHOR
-blockdev was written by Andries E. Brouwer and rewritten by Karel Zak.
+blockdev was written by Andries E.\& Brouwer and rewritten by Karel Zak.
 .SH AVAILABILITY
 The blockdev command is part of the util-linux package and is available from
 ftp://ftp.kernel.org/pub/linux/utils/util-linux/.

Re: [PATCH] blockdev(8): Some minor corrections to the manual

[Sami Kerola]

On 3 April 2014 00:23, Bjarni Ingi Gislason <bjarniig@rhi.hi.is> wrote:
>   Patch is in the attachment

Hi Bjarni,

Great to see new contributor.

It seems you are sending quite a few patches, and it would be better
to get them in git native format. Looking your message I think you
have downloaded release package, made changes and used 'diff -u'.
That's not too bad when sending a small number of changes. To me your
number your patches is exceeding what I would describe as small
number.

Could you get yourself a clone of this project. Configure your git,
and resubmit.

git clone git://git.kernel.org/pub/scm/utils/util-linux/util-linux.git
util-linux
git config --global user.name "Bjarni Ingi Gislason"
git config --global user.email bjarniig@rhi.hi.is
git branch bjani
git checkout bjarni
# while patches {
git apply <each of your patch separately>
git add .
git commit -s
# }

# create patches
git format-patch -n master ~/ul-patches/

# test that you can send/receive emails
git send-email --to bjarniig@rhi.hi.is ~/ul-patches/*
# if yes, and all looks good
git send-email --to util-linux@vger.kernel.org ~/ul-patches/*

If you end struggling with email for hours it might be easier to save
all files in ul-patches directory to a single tar.gz file, and send it
as an attachment. This is not quite as good as seeing patches in email
list as message body, but at least the patches would be in easy to
process format.

-- 
Sami Kerola
http://www.iki.fi/kerolasa/

Re: [PATCH] blockdev(8): Some minor corrections to the manual

[Karel Zak]

> On 3 April 2014 00:23, Bjarni Ingi Gislason <bjarniig@rhi.hi.is> wrote:
> >   Patch is in the attachment

 Bjarni, I have merged all your patches, but Sami is right. It would
 be nice to have your patches in better format next time. Thanks!

    Karel

On Thu, Apr 03, 2014 at 09:49:54AM +0100, Sami Kerola wrote:
> git clone git://git.kernel.org/pub/scm/utils/util-linux/util-linux.git
> util-linux
> git config --global user.name "Bjarni Ingi Gislason"
> git config --global user.email bjarniig@rhi.hi.is
> git branch bjani
> git checkout bjarni
> # while patches {
> git apply <each of your patch separately>
> git add .
> git commit -s
> # }
> 
> # create patches
> git format-patch -n master ~/ul-patches/
> 
> # test that you can send/receive emails
> git send-email --to bjarniig@rhi.hi.is ~/ul-patches/*
> # if yes, and all looks good
> git send-email --to util-linux@vger.kernel.org ~/ul-patches/*

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: [PATCH] blockdev(8): Some minor corrections to the manual

[Bjarni Ingi Gislason]

On Mon, Apr 07, 2014 at 12:36:04PM +0200, Karel Zak wrote:
> > On 3 April 2014 00:23, Bjarni Ingi Gislason <bjarniig@rhi.hi.is> wrote:
> > >   Patch is in the attachment
> 
>  Bjarni, I have merged all your patches, but Sami is right. It would
>  be nice to have your patches in better format next time. Thanks!
> 

  I have compiled "git", but I still have to get acquainted with (test
how to use) it.

  There are more man pages in "git", that I imagined, so it is better
that I learn to use it instead of just using "diff -u ...", which causes
other people more work.

-- 
Bjarni I. Gislason