public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: Ruediger Meier <sweet_f_a@gmx.de>,
	util-linux <util-linux@vger.kernel.org>
Subject: Re: question about test suite regarding stderr/stdout
Date: Mon, 12 May 2014 12:53:32 +0200	[thread overview]
Message-ID: <20140512105332.GC8951@x2.net.home> (raw)
In-Reply-To: <CAG27Bk0dj=SOiGY5Hb6VttoTZG7o4P2X=XPRV6vc82g0yheybw@mail.gmail.com>

On Mon, May 12, 2014 at 12:22:46AM +0100, Sami Kerola wrote:
> On 11 May 2014 23:38, Ruediger Meier <sweet_f_a@gmx.de> wrote:
> > if you do this grep in util-linux
> >   git grep '2>&1 >> $TS_OUTPUT' tests/ts
> >
> > then you find 45 lines like this
> > $TS_CMD_MKCRAMFS -n $LABEL $IMAGE_SRC $IMAGE_PATH 2>&1 >> $TS_OUTPUT
> >
> >
> > which means that these warnings go to make's output but not to
> > $TS_OUTPUT.
> >
> > I'm not sure whether this is really always wanted. For me it often looks
> > like a typo which should be ">> $TS_OUTPUT 2>&1" instead. Of course
> > could also be that it's really wanted as is to ignore stderr of too
> > verbose commands.
> >
> > Could somebody please check this too?
> > I'v had some cases where I would have liked to see that stderr in test
> > diff instead of build log. Moreover because of parallel tests it can be
> > difficult to find out which warning belongs to which particular test.
> 
> Hi Rudi,
> 
> Before parallel tests sending messages to stdout was OK, but now
> things has changed and I think directing all messages to $TS_OUTPUT is
> better option.

 That's usually correct and wanted, but note that some utils generate
 non-generic and irrelevant messages on stdout (for example messages 
 with device names). You cannot log such stuff to $TS_OUTPUT, so
 sometimes it's better to rely on stderr only and ignore stdout.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply	other threads:[~2014-05-12 10:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-11 22:38 question about test suite regarding stderr/stdout Ruediger Meier
2014-05-11 23:22 ` Sami Kerola
2014-05-12 10:53   ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512105332.GC8951@x2.net.home \
    --to=kzak@redhat.com \
    --cc=kerolasa@gmail.com \
    --cc=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox