Re: [PATCH 1/4] Avoid that agetty nor sulogin are fooled by a running plymouth

[Karel Zak <kzak@redhat.com>]

On Thu, May 08, 2014 at 12:09:22PM +0200, Werner Fink wrote:
> The nowadays used plymouth locks the devices used for the system
> console which causes that agetty as well as sulogin can not modify
> the termios settings of e.g. the serial devices of the systenm console.

 All applied, thanks!

> +	int fd = con->fd, i = (plymouth_command("--ping")) ? 20 : 0;
> +
> +	while (i-- > 0) {
> +		/*
> +		 * With plymouth the termios flags become changed after this
> +		 * function had changed the termios.
> +		 */
> +		memset(&lock, 0, sizeof(struct termios));
> +		if (ioctl(fd, TIOCGLCKTRMIOS, &lock) < 0)
> +			break;
> +		if (!lock.c_iflag && !lock.c_oflag && !lock.c_cflag && !lock.c_lflag)
> +			break;
> +		if (i == 15 && plymouth_command("quit") != 0)
> +			break;
> +		sleep(1);
> +	}
> +	memset(&lock, 0, sizeof(struct termios));
> +	ioctl(fd, TIOCSLCKTRMIOS, &lock);

 I hope 20s sleep is the worst case and in normal situations we don't
 have to call plymouth "quit" from sulogin/agetty.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com