From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: util-linux-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:26571 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752831AbaESJ5U (ORCPT ); Mon, 19 May 2014 05:57:20 -0400 Date: Mon, 19 May 2014 11:57:11 +0200 From: Karel Zak To: Sami Kerola Cc: util-linux@vger.kernel.org Subject: Re: [PATCH 11/17] setterm: correct usage() bright color argument Message-ID: <20140519095711.GJ26357@x2.net.home> References: <1400421941-14244-1-git-send-email-kerolasa@iki.fi> <1400421941-14244-12-git-send-email-kerolasa@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1400421941-14244-12-git-send-email-kerolasa@iki.fi> Sender: util-linux-owner@vger.kernel.org List-ID: On Sun, May 18, 2014 at 03:05:35PM +0100, Sami Kerola wrote: > fputs(_(" -foreground \n"), out); > fputs(_(" -background \n"), out); > - fputs(_(" -ulcolor \n"), out); > - fputs(_(" -ulcolor \n"), out); > - fputs(_(" -hbcolor \n"), out); > - fputs(_(" -hbcolor \n"), out); > + fputs(_(" -ulcolor \n"), out); > + fputs(_(" -ulcolor \n"), out); > + fputs(_(" -hbcolor \n"), out); > + fputs(_(" -hbcolor \n"), out); too many duplicate information, it would be better to use _(" -foreground |\n") ... _(" -hbcolor \n") and describe below in usage(): _(" means black, blue, ...") Karel -- Karel Zak http://karelzak.blogspot.com