From: Karel Zak <kzak@redhat.com>
To: Stanislav Brabec <sbrabec@suse.cz>
Cc: Ruediger Meier <sweet_f_a@gmx.de>,
util-linux@vger.kernel.org, Petr Uzel <petr.uzel@suse.cz>
Subject: Re: [PATCH 0/5] lscpu: improve hypervisor detection
Date: Wed, 21 May 2014 10:24:37 +0200 [thread overview]
Message-ID: <20140521082437.GC2898@x2.net.home> (raw)
In-Reply-To: <1400603662.5497.86.camel@oct.suse.cz>
On Tue, May 20, 2014 at 06:34:22PM +0200, Stanislav Brabec wrote:
> Ruediger Meierwrote:
>
> > I've splitted the original patch into smaller pieces, removed some
> > incompatible output format changes and added some test data.
>
> There was a controversial part of this patch, that causes test failure.
>
> There should be a way how to output result of the virtual machine
> detection without breaking test cases (and possibly existing scripts).
Like many other utils we have a way how to specify output columns
lscpu --extended[=<list>]
lscpu --parse[=<list>]
The man page:
-p, --parse[=list]
If the list argument is omitted, the command output is compatible
with earlier versions of lscpu.
it means that HvVendor,VirtType have to be omitted from -p by default.
Frankly, I don't see any practical reason to have hypervisor info in -p
and -e at all. These output formats are about CPU topology and per-CPU
specific information. The global stuff makes more sense for the default
(without options) output where you can use
lscpu | awk '/Hypervisor type/ { print $2 }'
or so...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-05-21 8:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 15:42 [PATCH 0/5] lscpu: improve hypervisor detection Ruediger Meier
2014-05-20 15:42 ` [PATCH 1/5] lscpu: minor cleanup and " Ruediger Meier
2014-05-20 15:42 ` [PATCH 2/5] tests: add vbox lscpu dump Ruediger Meier
2014-05-20 15:42 ` [PATCH 3/5] lscpu: detect OS/400 and pHyp hypervisors Ruediger Meier
2014-05-21 7:37 ` Karel Zak
2014-05-21 9:43 ` Ruediger Meier
2014-05-21 12:41 ` Karel Zak
2014-05-21 23:03 ` Ruediger Meier
2014-05-22 8:48 ` Karel Zak
2014-05-22 9:08 ` Heiko Carstens
2014-05-22 9:30 ` Alexander Graf
2014-05-28 21:54 ` Ruediger Meier
2014-05-28 22:29 ` Alexander Graf
2014-05-20 15:42 ` [PATCH 4/5] lscpu: improve vmware detection Ruediger Meier
2014-05-20 18:40 ` Ruediger Meier
2014-05-20 15:42 ` [PATCH 5/5] lscpu: avoid compiler warnings Ruediger Meier
2014-05-21 8:10 ` Karel Zak
2014-05-20 16:34 ` [PATCH 0/5] lscpu: improve hypervisor detection Stanislav Brabec
2014-05-20 18:13 ` Ruediger Meier
2014-05-21 8:24 ` Karel Zak [this message]
2014-05-21 22:29 ` Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521082437.GC2898@x2.net.home \
--to=kzak@redhat.com \
--cc=petr.uzel@suse.cz \
--cc=sbrabec@suse.cz \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox