Re: [PATCH] deadlock in script

[Karel Zak <kzak@redhat.com>]

On Fri, May 30, 2014 at 06:52:20PM +0900, Csaba Kos wrote:
> On Fri, May 30, 2014 at 6:15 PM, Karel Zak <kzak@redhat.com> wrote:
> > On Fri, May 30, 2014 at 03:30:45PM +0900, Csaba Kos wrote:
> >> diff --git a/term-utils/script.c b/term-utils/script.c
> >> index e5d239c..32906d0 100644
> >> --- a/term-utils/script.c
> >> +++ b/term-utils/script.c
> >> @@ -36,6 +36,9 @@
> >>   * - added Native Language Support
> >>   *
> >>   * 2000-07-30 Per Andreas Buer <per@linpro.no> - added "q"-option
> >> + *
> >> + * 2014-05-30 Csaba Kos <csaba.kos@gmail.com>
> >> + * - fixed a rare deadlock after child termination
> >>   */
> >>
> >>  /*
> >> @@ -114,6 +117,8 @@ int       tflg = 0;
> >>  int  forceflg = 0;
> >>  int  isterm;
> >>
> >> +sigset_t block_mask, unblock_mask;
> >
> >  This declaration shadows declaration in main() where is also block_mask and
> >  unblock_mask -- I guess it's not expected.
> 
> Sorry, I goofed when updating my patch to the current master. Thanks
> for the careful review! Updated patch attached.

 All applied, thanks!

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com