public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Reisner <d@falconindy.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org, Tobias Klausmann <klausman@schwarzvogel.de>
Subject: Re: [PATCH] libfdisk: fix bsd_translate_fstype() for alpha
Date: Sun, 8 Jun 2014 09:44:33 -0400	[thread overview]
Message-ID: <20140608134433.GC2336@rampage> (raw)
In-Reply-To: <1402234368-17174-1-git-send-email-sweet_f_a@gmx.de>

On Sun, Jun 08, 2014 at 03:32:48PM +0200, Ruediger Meier wrote:
> From: Ruediger Meier <ruediger.meier@ga-group.nl>
> 
> Reported-by: Tobias Klausmann <klausman@schwarzvogel.de>
> Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
> ---
>  libfdisk/src/bsd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libfdisk/src/bsd.c b/libfdisk/src/bsd.c
> index a81afd2..df0fc13 100644
> --- a/libfdisk/src/bsd.c
> +++ b/libfdisk/src/bsd.c
> @@ -773,8 +773,10 @@ static int bsd_translate_fstype (int linux_type)
>  	case 0x06: /* DOS 16-bit >=32M */
>  	case 0xe1: /* DOS access       */
>  	case 0xe3: /* DOS R/O          */
> +#if !defined (__alpha__)
>  	case 0xf2: /* DOS secondary    */
>  		return BSD_FS_MSDOS;
> +#endif

What would be the harm on defining this for platforms which don't
include it? Why is a partition type excluded from this architecture?

>  	case 0x07: /* OS/2 HPFS        */
>  		return BSD_FS_HPFS;
>  	default:
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-06-08 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-08 10:42 util-linux breakage with v2.24.2 on Alpha Tobias Klausmann
2014-06-08 12:25 ` Ruediger Meier
2014-06-08 12:44   ` Tobias Klausmann
2014-06-08 13:32 ` [PATCH] libfdisk: fix bsd_translate_fstype() for alpha Ruediger Meier
2014-06-08 13:44   ` Dave Reisner [this message]
2014-06-08 14:09     ` Tobias Klausmann
2014-06-08 15:06       ` Ruediger Meier
2014-06-09  8:43   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140608134433.GC2336@rampage \
    --to=d@falconindy.com \
    --cc=klausman@schwarzvogel.de \
    --cc=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox