From: Karel Zak <kzak@redhat.com>
To: David Shea <dshea@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Correct the return values in squashfs probe
Date: Tue, 24 Jun 2014 10:56:12 +0200 [thread overview]
Message-ID: <20140624085612.GB13203@x2.net.home> (raw)
In-Reply-To: <1403545308-18371-1-git-send-email-dshea@redhat.com>
On Mon, Jun 23, 2014 at 01:41:48PM -0400, David Shea wrote:
> libblkid/src/superblocks/squashfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> sq = blkid_probe_get_sb(pr, mag, struct sqsh_super_block);
> if (!sq)
> - return -1;
> + return 1;
Note that the current libblkid code is sensitive to IO errors, so the
correct changes is
return errno ? -errno : 1;
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-06-24 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 17:41 [PATCH] Correct the return values in squashfs probe David Shea
2014-06-24 8:56 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624085612.GB13203@x2.net.home \
--to=kzak@redhat.com \
--cc=dshea@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox