From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: "Pádraig Brady" <P@draigBrady.com>,
"util-linux@vger.kernel.org" <util-linux@vger.kernel.org>
Subject: Re: fallocate: --punch option parsing error diagnostics irritating
Date: Thu, 26 Jun 2014 14:49:37 +0200 [thread overview]
Message-ID: <20140626124937.GB750@x2.net.home> (raw)
In-Reply-To: <53AC0E89.4020300@bernhard-voelker.de>
On Thu, Jun 26, 2014 at 02:14:01PM +0200, Bernhard Voelker wrote:
> The patch below fixes it.
Applied, thanks.
> BTW: I think fallocate(1) shouldn't open(...,O_CREAT)
> with -d, -p, and maybe with -z, should it?
Good catch, I think O_CREAT makes sense only for the default
fallocate(2) behavior when no mode is specified and new file is
allocated. All another modes work with existing data/holes.
Fixed.
Karel
PS. I love this on-line development and brain storming, git & OSS is
the best :-)
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-06-26 12:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 20:16 fallocate: --punch option parsing error diagnostics irritating Bernhard Voelker
2014-06-25 20:35 ` Dale R. Worley
2014-06-26 10:10 ` Karel Zak
2014-06-26 10:52 ` Pádraig Brady
2014-06-26 11:07 ` Karel Zak
2014-06-26 12:14 ` Bernhard Voelker
2014-06-26 12:49 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626124937.GB750@x2.net.home \
--to=kzak@redhat.com \
--cc=P@draigBrady.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox