util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] uuidd.rc: drop on-demand mode from script
@ 2014-07-11 13:08 Andreas Henriksson
  2014-07-11 13:08 ` [PATCH 2/2] uuidd.rc: Requires remote_fs Andreas Henriksson
  2014-07-14 13:56 ` [PATCH 1/2] uuidd.rc: drop on-demand mode from script Karel Zak
  0 siblings, 2 replies; 4+ messages in thread
From: Andreas Henriksson @ 2014-07-11 13:08 UTC (permalink / raw)
  To: util-linux; +Cc: Andreas Henriksson

The on-demand mode was dropped from libuuid in
commit ea4f8845f0241c7 "libuuid: don't exec uuidd"

You now need systemd (socket activation) to use
uuidd on demand.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 misc-utils/uuidd.rc.in | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/misc-utils/uuidd.rc.in b/misc-utils/uuidd.rc.in
index 27b75c6..3c5528a 100644
--- a/misc-utils/uuidd.rc.in
+++ b/misc-utils/uuidd.rc.in
@@ -13,11 +13,6 @@
 #
 set -e
 
-# libuuid is able to execute the uuid daemon on-demand -- in such a case
-# the daemon binary must be setuid to an unprivileged user (e.g. uuidd:uuidd).
-#                                                    [-- kzak Jun 2009]
-UUIDD_ON_DEMAND_ONLY="no"
-
 PATH=/bin:/usr/bin:/sbin:/usr/sbin
 DAEMON=/usr/sbin/uuidd
 UUIDD_USER=uuidd
@@ -36,11 +31,7 @@ case "$1" in
 		mkdir -p $UUIDD_DIR
 		chown -R $UUIDD_USER:$UUIDD_GROUP $UUIDD_DIR
 	fi
-	if test "$UUIDD_ON_DEMAND_ONLY" = yes; then
-		echo -n "(on demand only)"
-	else
-		start_daemon -p $PIDFILE $DAEMON
-	fi
+	start_daemon -p $PIDFILE $DAEMON
 	log_end_msg $?
     ;;
   stop)
-- 
2.0.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] uuidd.rc: Requires remote_fs
  2014-07-11 13:08 [PATCH 1/2] uuidd.rc: drop on-demand mode from script Andreas Henriksson
@ 2014-07-11 13:08 ` Andreas Henriksson
  2014-07-14 13:56   ` Karel Zak
  2014-07-14 13:56 ` [PATCH 1/2] uuidd.rc: drop on-demand mode from script Karel Zak
  1 sibling, 1 reply; 4+ messages in thread
From: Andreas Henriksson @ 2014-07-11 13:08 UTC (permalink / raw)
  To: util-linux; +Cc: Andreas Henriksson

The Debian package checking tool lintian thinks that the script is
missing Requires on $remote_fs because it pokes at stuff under /usr
and it's probably right.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 misc-utils/uuidd.rc.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc-utils/uuidd.rc.in b/misc-utils/uuidd.rc.in
index 3c5528a..cebe228 100644
--- a/misc-utils/uuidd.rc.in
+++ b/misc-utils/uuidd.rc.in
@@ -1,8 +1,8 @@
 #! /bin/sh -e
 ### BEGIN INIT INFO
 # Provides:          uuidd
-# Required-Start:    $time $local_fs
-# Required-Stop:     $time $local_fs
+# Required-Start:    $time $local_fs $remote_fs
+# Required-Stop:     $time $local_fs $remote_fs
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: uuidd daemon
-- 
2.0.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] uuidd.rc: drop on-demand mode from script
  2014-07-11 13:08 [PATCH 1/2] uuidd.rc: drop on-demand mode from script Andreas Henriksson
  2014-07-11 13:08 ` [PATCH 2/2] uuidd.rc: Requires remote_fs Andreas Henriksson
@ 2014-07-14 13:56 ` Karel Zak
  1 sibling, 0 replies; 4+ messages in thread
From: Karel Zak @ 2014-07-14 13:56 UTC (permalink / raw)
  To: Andreas Henriksson; +Cc: util-linux

On Fri, Jul 11, 2014 at 03:08:40PM +0200, Andreas Henriksson wrote:
>  misc-utils/uuidd.rc.in | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

 Good catch! Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] uuidd.rc: Requires remote_fs
  2014-07-11 13:08 ` [PATCH 2/2] uuidd.rc: Requires remote_fs Andreas Henriksson
@ 2014-07-14 13:56   ` Karel Zak
  0 siblings, 0 replies; 4+ messages in thread
From: Karel Zak @ 2014-07-14 13:56 UTC (permalink / raw)
  To: Andreas Henriksson; +Cc: util-linux

On Fri, Jul 11, 2014 at 03:08:41PM +0200, Andreas Henriksson wrote:
>  misc-utils/uuidd.rc.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

 Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-14 13:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 13:08 [PATCH 1/2] uuidd.rc: drop on-demand mode from script Andreas Henriksson
2014-07-11 13:08 ` [PATCH 2/2] uuidd.rc: Requires remote_fs Andreas Henriksson
2014-07-14 13:56   ` Karel Zak
2014-07-14 13:56 ` [PATCH 1/2] uuidd.rc: drop on-demand mode from script Karel Zak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).