util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] buildsys: make tailf linux-only (needs inotify)
@ 2014-07-26 17:01 Andreas Henriksson
  2014-07-26 20:26 ` Andreas Henriksson
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Henriksson @ 2014-07-26 17:01 UTC (permalink / raw)
  To: util-linux; +Cc: Andreas Henriksson

While tailf builds fine on other architectures, it relies
on inotify to work properly. So for example on
Debian architectures using Hurd or kFreeBSD tailf
would work like a regular tail (with a non-functional
-f option), which makes it quite redundant.
This was caught by the util-linux testsuite.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
 configure.ac | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index aae2456..eade79c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1272,7 +1272,8 @@ AM_CONDITIONAL([BUILD_HEXDUMP], [test "x$build_hexdump" = xyes])
 UL_BUILD_INIT([rev], [yes])
 AM_CONDITIONAL([BUILD_REV], [test "x$build_rev" = xyes])
 
-UL_BUILD_INIT([tailf], [yes])
+UL_BUILD_INIT([tailf], [check])
+UL_REQUIRES_LINUX([tailf])
 AM_CONDITIONAL([BUILD_TAILF], [test "x$build_tailf" = xyes])
 
 
-- 
2.0.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] buildsys: make tailf linux-only (needs inotify)
  2014-07-26 17:01 [PATCH] buildsys: make tailf linux-only (needs inotify) Andreas Henriksson
@ 2014-07-26 20:26 ` Andreas Henriksson
  0 siblings, 0 replies; 2+ messages in thread
From: Andreas Henriksson @ 2014-07-26 20:26 UTC (permalink / raw)
  To: util-linux

Hello all!

On Sat, Jul 26, 2014 at 07:01:11PM +0200, Andreas Henriksson wrote:
> While tailf builds fine on other architectures, it relies
> on inotify to work properly. So for example on
[...]

Please ignore this! I was to quick to judge. The program
has non-inotify fallback code which does work... this is
likely just a problem in the testsuite.
I'll follow up shortly.

Regards,
Andreas Henriksson

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-26 20:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-26 17:01 [PATCH] buildsys: make tailf linux-only (needs inotify) Andreas Henriksson
2014-07-26 20:26 ` Andreas Henriksson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).