From: Karel Zak <kzak@redhat.com>
To: Andreas Henriksson <andreas@fatal.se>
Cc: "Pádraig Brady" <P@draigBrady.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] tests: allow non-inotify tailf to keep up
Date: Tue, 29 Jul 2014 12:19:16 +0200 [thread overview]
Message-ID: <20140729101916.GT8533@x2.net.home> (raw)
In-Reply-To: <20140728122115.GA17573@fatal.se>
On Mon, Jul 28, 2014 at 02:21:15PM +0200, Andreas Henriksson wrote:
> Hello!
>
> On Mon, Jul 28, 2014 at 01:59:23PM +0200, Karel Zak wrote:
> > On Sun, Jul 27, 2014 at 01:36:01PM +0100, Pádraig Brady wrote:
> > > For such tests coreutils uses a helper function
> > > to apply a truncated exponential backoff,
> > > to run quickly in the common case, but also
> > > delay longer if necessary. See retry_delay_() at:
>
> Thanks for the pointer!
>
> > >
> > > http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=init.cfg;h=725ee121;hb=HEAD#l608
> >
> > Andreas? (hint: send a new patch :-))
>
> I fail to see how this is useful here. We either need a short delay (using
> inotify) or a longer delay (not using inotify). All other steps seems
> pointless to me, even harmful in non-inotify case!
OK, merged. Maybe someone will provide a better solution later.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2014-07-29 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 20:44 [PATCH] tests: allow non-inotify tailf to keep up Andreas Henriksson
2014-07-27 12:36 ` Pádraig Brady
2014-07-28 11:59 ` Karel Zak
2014-07-28 12:21 ` Andreas Henriksson
2014-07-29 10:19 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729101916.GT8533@x2.net.home \
--to=kzak@redhat.com \
--cc=P@draigBrady.com \
--cc=andreas@fatal.se \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox