public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 8/8] zramctl: allow use of --algorithm and --streams alone
Date: Mon, 4 Aug 2014 13:55:56 +0200	[thread overview]
Message-ID: <20140804115556.GA6923@x2.net.home> (raw)
In-Reply-To: <1407107290-5806-1-git-send-email-kerolasa@iki.fi>

On Mon, Aug 04, 2014 at 12:08:10AM +0100, Sami Kerola wrote:
> Earlier the --algorithm and --streams had to be combined with --size.  To
> user requirement to combine with --size was indirectly told using
> following message.

And is it really supported by kernel? I see in
Documentation/blockdev/zram.txt:

 In order to enable compression backend's multi stream support
 max_comp_streams must be initially set to desired concurrency 
 level before ZRAM device initialisation.

I guess that when you set disksize the zram device is "locked" for
setting changes. It means that modify already initialized (created)
zram devices is impossible. You have to reset the device to "unlock"
the device setting.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  parent reply	other threads:[~2014-08-04 11:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-03 23:08 [PATCH 8/8] zramctl: allow use of --algorithm and --streams alone Sami Kerola
2014-08-03 23:24 ` Bernhard Voelker
2014-08-04 11:55 ` Karel Zak [this message]
2014-08-05 22:36   ` Sami Kerola
2014-08-06  8:20     ` Karel Zak
2014-08-06 12:19     ` Sergey Senozhatsky
2014-08-06 20:48       ` Sami Kerola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140804115556.GA6923@x2.net.home \
    --to=kzak@redhat.com \
    --cc=kerolasa@iki.fi \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox