From: Ruediger Meier <sweet_f_a@gmx.de>
To: Adam Sampson <ats@offog.org>
Cc: Karel Zak <kzak@redhat.com>, util-linux@vger.kernel.org
Subject: Re: [ANNOUNCE] util-linux v2.25.1
Date: Thu, 4 Sep 2014 00:19:11 +0200 [thread overview]
Message-ID: <201409040019.12248.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20140903155554.GS885@cartman.at.offog.org>
On Wednesday 03 September 2014, Adam Sampson wrote:
> On Wed, Sep 03, 2014 at 12:54:27PM +0200, Karel Zak wrote:
> > - make ipcs limit calculations work when numbers are large
>
> That change isn't right -- it reverses the sense of the test, making
> the testcase fail on 3.16 again. Patch attached.
Your patch seems to be correct except that it should be "<=" instead
of "<":
if [ $(bc <<<"2^64 / $PAGE_SIZE <= $SHMALL") -eq 1 ]; then
to have the same (correct) behavior like before 3a9ec12d.
The mistake in 3a9ec12d happened probably because Sami tried to
avoid "greater than" relations. but for my brain this line would be
still more easy to read:
if [ $(bc <<<"$SHMALL >= 2^64 / $PAGE_SIZE") -eq 1 ]; then
Maybe that's why me and others have not noticed the mistake when
reviewing that patch.
cu,
Rudi
next prev parent reply other threads:[~2014-09-03 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 10:54 [ANNOUNCE] util-linux v2.25.1 Karel Zak
2014-09-03 15:55 ` Adam Sampson
2014-09-03 22:19 ` Ruediger Meier [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-06 7:27 Sami Kerola
2014-09-06 8:51 ` Ruediger Meier
2014-10-01 8:14 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409040019.12248.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=ats@offog.org \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).