From: Karel Zak <kzak@redhat.com>
To: Andreas Henriksson <andreas@fatal.se>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 4/5] build-sys: swaplabel needs libmount
Date: Mon, 22 Sep 2014 13:27:03 +0200 [thread overview]
Message-ID: <20140922112703.GH5366@x2.net.home> (raw)
In-Reply-To: <1411086439-8247-1-git-send-email-andreas@fatal.se> <1411083397-8056-4-git-send-email-andreas@fatal.se>
On Fri, Sep 19, 2014 at 01:36:36AM +0200, Andreas Henriksson wrote:
> The swaplabel utility uses libmount functionality and
> thus libmount has to be available if we want to build
> swaplabel. This change makes swaplabel be automatically
> disabled when we don't.
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
On Fri, Sep 19, 2014 at 02:27:19AM +0200, Andreas Henriksson wrote:
> The swapoff utility seems to need linking with libblkid otherwise
> this build error occurs:
>
> $ git describe
> v2.25-180-g29607ed
> $ ./autogen.sh && ./configure --without-python && make
> [....]
> CCLD swapoff
> /usr/bin/ld: sys-utils/swapoff-swapon-common.o: undefined reference to symbol 'blkid_probe_lookup_value@@BLKID_2.15'
> //home/ah/opt/pkg-util-linux/util-linux/.libs/libblkid.so.1: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> Makefile:5992: recipe for target 'swapoff' failed
> make[2]: *** [swapoff] Error 1
> make[2]: Leaving directory '/home/ah/opt/pkg-util-linux/util-linux'
> Makefile:10220: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/home/ah/opt/pkg-util-linux/util-linux'
> Makefile:4433: recipe for target 'all' failed
> make: *** [all] Error 2
>
> ---
> sys-utils/Makemodule.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I have modified swapoff, swapon and swaplabel to use separate file
lib/swapprobe.c for libblkid stuff. So now:
swapon - requires libmount and libblkid
swapoff - requires libmount
swaplabel - requires libblkid
link directly both libs everywhere is overkill. Please, test the
current git tree. Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-09-22 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 23:36 [PATCH 1/5] libmount: only invoke loopcxt on linux Andreas Henriksson
2014-09-18 23:36 ` [PATCH 2/5] libmount: only include context " Andreas Henriksson
2014-09-18 23:36 ` [PATCH 3/5] build-sys: build libmount everywhere Andreas Henriksson
2014-09-18 23:36 ` [PATCH 4/5] build-sys: swaplabel needs libmount Andreas Henriksson
2014-09-22 11:27 ` Karel Zak [this message]
2014-09-18 23:36 ` [PATCH 5/5] logger: gettimeofday needs <sys/time.h> Andreas Henriksson
2014-09-22 11:21 ` [PATCH 1/5] libmount: only invoke loopcxt on linux Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2014-09-19 0:27 [PATCH] build-sys: link swapoff to libblkid Andreas Henriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922112703.GH5366@x2.net.home \
--to=kzak@redhat.com \
--cc=andreas@fatal.se \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).