From: Karel Zak <kzak@redhat.com>
To: kerolasa@gmail.com
Cc: JWP <elseifthen@gmx.com>, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 1/7] hwclock: hctosys drift compensation II
Date: Tue, 14 Oct 2014 12:27:37 +0200 [thread overview]
Message-ID: <20141014102737.GT8057@x2.net.home> (raw)
In-Reply-To: <CAG27Bk3x9YsB0sK+3ftPG4P_i8mK-en4BB=WoTjvPfpLvOLmOA@mail.gmail.com>
On Tue, Oct 14, 2014 at 10:51:30AM +0100, Sami Kerola wrote:
> On 14 October 2014 10:03, Karel Zak <kzak@redhat.com> wrote:
> > Maybe it would be better to think about whole code refactoring as it's
> > horrible code. It's probably last so horrible code in util-linux.
>
> Along with more(1). I started to look this refactoring task, and it
> seems reimplementation would be best option. Does someone fancy a
> programming challenge?
I prefer refactoring if possible than write things from scratch. And
for hwclock it's really critical to do the changes in small testable
steps.
Note that sfdisk and cfdisk are completely new because we have libfdisk that
replaces all the original cfdisk and sfdisk partitioning code. The
library itself is refactored and incrementally changed fdisk code.
> Few disk utils, cramfs, bfs, and minix related, could also be improved
> or marked deprecated. I am hoping for later.
Well, I don't think we can deprecated these tools and I don't think
that cramfs, minix and bfs code is so bad. For example mkfs.minix
has been clean upped by Davidlohr Bueso years ago. A few global
variables don't not mean that the code is bad...
Compare to hwclock it's like apples and oranges ;-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-10-14 10:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 15:16 [PATCH 0/7] hwclock patch cover letter JWP
2014-09-27 15:29 ` [PATCH 1/7] hwclock: hctosys drift compensation II JWP
2014-09-28 17:55 ` Sami Kerola
2014-09-29 16:48 ` JWP
2014-10-14 9:03 ` Karel Zak
2014-10-14 9:51 ` Sami Kerola
2014-10-14 10:27 ` Karel Zak [this message]
2014-10-16 23:21 ` JWP
2014-10-20 12:05 ` Karel Zak
2014-10-20 23:35 ` JWP
2014-10-21 9:38 ` Karel Zak
2014-09-27 15:29 ` [PATCH 2/7] hwclock: hctosys drift compensation II COMMENTS JWP
2014-09-27 15:29 ` [PATCH 3/7] hwclock: hctosys drift compensation II MAN JWP
2014-09-27 15:29 ` [PATCH 4/7] hwclock: persistent_clock_is_local JWP
2014-09-27 15:29 ` [PATCH 5/7] hwclock: persistent_clock_is_local MAN JWP
2014-09-27 15:30 ` [PATCH 6/7] hwclock: Add --update option JWP
2014-10-14 9:51 ` Karel Zak
2014-09-27 15:30 ` [PATCH 7/7] hwclock: Add --update option MAN JWP
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014102737.GT8057@x2.net.home \
--to=kzak@redhat.com \
--cc=elseifthen@gmx.com \
--cc=kerolasa@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).