Re: swapon: fix -d short option

[Robert Milasan <rmilasan@suse.com>]

On Tue, 21 Oct 2014 11:55:25 +0200
"Karel Zak" <kzak@redhat.com> wrote:

> On Tue, Oct 21, 2014 at 10:02:46AM +0200, Robert Milasan wrote:
> > When -d option is used with swapon, is expected that there is an
> > equal '=' which at least according to the man page it doesn't make
> > sense or it's not properly explained.
> 
> Well, in the man page there was incorrectly extra space between -d and
> the optional argument. Fixed yesterday.
> 
> > If we use -d as we should, then swapon takes 'once' or 'pages' as an
> > actual device:
> > 
> > dhcp33:~ # swapon -p -2 -d once /dev/sdb1
> > swapon: stat failed once: No such file or directory
> > 
> > The short option -d, should be something like "swapon -d once ...."
> > not "swapon -d=once ...."
> 
> What? The argument for -d is optional, it's reason why we care about
> '='. I think it's obvious from the code.
> 
>    swapon -p -2 -d /dev/sdb1 
> 
> is pretty valid.
> 
> Note that -d,--discard has been implemented in 2010, and extended by
> 'once' and 'pages' later in 2013.
> 
> > I've attached the patch to fix this small issue.
> 
> Sorry, but the patch does not make sense.
> 
>     Karel
> 

Sorry, but the option doesn't make sense eider. First is not documented
properly or at all and with my patch -d option without any argument
still works.

Thanks anyway!

-- 
Robert Milasan

L3 Support Engineer
SUSE Linux (http://www.suse.com)
email: rmilasan@suse.com
GPG fingerprint: B6FE F4A8 0FA3 3040 3402  6FE7 2F64 167C 1909 6D1A