From: Karel Zak <kzak@redhat.com>
To: JWP <elseifthen@gmx.com>
Cc: Benno Schulenberg <bensberg@justemail.net>,
Util-Linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 2/5] hwclock: clean up message periods/full stops
Date: Fri, 24 Oct 2014 14:59:39 +0200 [thread overview]
Message-ID: <20141024125939.GD10134@x2.net.home> (raw)
In-Reply-To: <544A4817.3070406@gmx.com>
On Fri, Oct 24, 2014 at 08:37:43AM -0400, JWP wrote:
> My sincere oligopolies to translators, but hwclock is slated for refactoring
> and I expect many message changes will be included. Hopefully, the changes
> will include improving things for translators.
If you really plan to do the refactoring then don't care about
messages at all. The result will be completely different code (I
hope:-). But what we need to to merge all the changes by one pull
request.
Note that the best is to start with date types, try to describe
hwclock by structs (hwclock_control, hwclock_adjtime, hwclock_hwops,
etc.), then write small functions that work with the structs and then
high level logic. See for example cfdisk.c, losetup.c, name.c...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-10-24 12:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 2:49 [PATCH 2/5] hwclock: clean up message periods/full stops JWP
2014-10-24 11:33 ` Benno Schulenberg
2014-10-24 12:37 ` JWP
2014-10-24 12:59 ` Karel Zak [this message]
2014-10-24 16:07 ` JWP
2014-10-24 20:58 ` Benno Schulenberg
2014-10-27 10:59 ` Karel Zak
2014-10-27 10:55 ` Karel Zak
2014-10-24 21:57 ` Lauri Nurmi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024125939.GD10134@x2.net.home \
--to=kzak@redhat.com \
--cc=bensberg@justemail.net \
--cc=elseifthen@gmx.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).