Re: [PATCH 0/6] pull: almost working AddressSanitizer support

Mike Frysinger
2014-11-12T18:52:10Z

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

On 12 Nov 2014 15:02, Sami Kerola wrote:
> On 12 November 2014 14:25, Karel Zak <kzak@redhat.com> wrote:
> > On Tue, Nov 11, 2014 at 10:49:02PM +0000, Sami Kerola wrote:
> >> printf(_("Setting up swapspace version %d, size = %s (%ju bytes)\n"),
> >> version, strsz, sz);
> >> + free(strsz);
> >
> > free-before-exit, you know what I think about it, right? :)
>
> Normally I would agree, but this case is bizarre. The mkswap will
> return 1 when compiled with clang -fsanitize=address without any
> message what is wrong. That's probably clang bug, which is a different
> topic all together. Adding the free() calls seems to make the
> immediate tests failure issue to go away, that is needed to automate
> sanitize. In case travis && address sanitation is not needed at all
> then these changes does not make sense.

i don't think adding a free to avoid a bug in clang is justified

at least gcc defines __SANITIZE_ADDRESS__ ... so you might be able to gate on
that with a comment pointing to an open bug report on the clang side
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]