Re: [PATCH 0/6] pull: almost working AddressSanitizer support

Sami Kerola
2014-11-12T15:02:07Z

On 12 November 2014 14:25, Karel Zak <kzak@redhat.com> wrote:
> On Tue, Nov 11, 2014 at 10:49:02PM +0000, Sami Kerola wrote:
>> printf(_("Setting up swapspace version %d, size = %s (%ju bytes)\n"),
>> version, strsz, sz);
>> + free(strsz);
>
> free-before-exit, you know what I think about it, right? :)

Normally I would agree, but this case is bizarre. The mkswap will
return 1 when compiled with clang -fsanitize=address without any
message what is wrong. That's probably clang bug, which is a different
topic all together. Adding the free() calls seems to make the
immediate tests failure issue to go away, that is needed to automate
sanitize. In case travis && address sanitation is not needed at all
then these changes does not make sense.

--
Sami Kerola