From: Karel Zak <kzak@redhat.com>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org, "Ville Skyttä" <ville.skytta@iki.fi>
Subject: Re: [PATCH] bash-completion: Invoke actual commands to be completed, not basenames
Date: Mon, 24 Nov 2014 12:40:35 +0100 [thread overview]
Message-ID: <20141124114035.GD926@x2.net.home> (raw)
In-Reply-To: <CA+mSPTjwXzTnMeRb+kBF1RGLCCE_LOXDTqPgZXjrdKWbm=y9qg@mail.gmail.com>
On Tue, Nov 18, 2014 at 09:28:51AM -0500, Dave Reisner wrote:
> On Nov 18, 2014 8:00 AM, "Karel Zak" <kzak@redhat.com> wrote:
> >
> > On Sat, Nov 15, 2014 at 10:36:04PM +0200, Ville Skyttä wrote:
> > > bash-completion/chsh | 2 +-
> > > bash-completion/eject | 2 +-
> > > bash-completion/findmnt | 8 ++++----
> > > bash-completion/losetup | 4 ++--
> > > bash-completion/lsblk | 2 +-
> > > bash-completion/setarch | 2 +-
> > > bash-completion/setpriv | 2 +-
> > > 7 files changed, 11 insertions(+), 11 deletions(-)
> >
> > Applied, thanks!
> >
> > Karel
> >
>
> I think this patch breaks completions when used with binaries from a build
> root containing whitespace in the path. The use is probably rare, but fix
For example?
> is simple -- quote the $1. The commands inside $() have their own separate
> level of quoting, i.e. "$("$1" -X)" is what we want.
Ville, any comment?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2014-11-24 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 14:28 [PATCH] bash-completion: Invoke actual commands to be completed, not basenames Dave Reisner
2014-11-24 11:40 ` Karel Zak [this message]
2014-11-24 15:25 ` Dave Reisner
-- strict thread matches above, loose matches on Subject: below --
2014-11-15 20:36 Ville Skyttä
2014-11-18 12:59 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124114035.GD926@x2.net.home \
--to=kzak@redhat.com \
--cc=d@falconindy.com \
--cc=util-linux@vger.kernel.org \
--cc=ville.skytta@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).