util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Dale R. Worley" <worley@alum.mit.edu>, util-linux@vger.kernel.org
Subject: Re: Fwd: Re: util-linux: libblkid: UDF superblock
Date: Tue, 9 Dec 2014 11:35:20 +0100	[thread overview]
Message-ID: <20141209103520.GK19904@x2.net.home> (raw)
In-Reply-To: <201412050325.06569@pali>

On Fri, Dec 05, 2014 at 03:25:06AM +0100, Pali Rohár wrote:
> On Friday 05 December 2014 03:09:11 Dale R. Worley wrote:
> > Pali Rohár <pali.rohar@gmail.com> writes:
> > >> So I think that it is better to use LogicalVolumeIdentifier
> > >> for libblkid LABEL. And not current VolumeIdentifier.
> > >> 
> > >> What do you think?
> > 
> > If you change how the LABEL value is read from the disk, every
> > user will see different LABEL values than they saw in the
> > past.
> > 
> > Dale
> 
> Yes, but apparently other systems are using LABEL from 
> LogicalVolumeIdentifier. So now you see different labels on 
> different systems which is not good too.
> 
> Also that bsd project UDFclient (which is working on Linux too!) 
> is using LogicalVolumeIdentifier as volume/disk name in newfs_udf 
> tool.
> 
> I looked into grub2 code and it is identifying UDF label also 
> from LogicalVolumeIdentifier. So if you want to boot something 
> from UDF FS via grub you probably see label problems...
> 
> So I think that rather than using broken linux implementation is 
> better to fix it (which could bring problems with different label 
> names in new version). And I would like to see human readable 
> label as "555e3160".

It's more important to not introduce regression, if you have LABEL= in
your fstab then you don't want to see that after util-linux update
your setting is obsolete and filesystem unmounted.

It would be possible use another header field (LogicalVolumeIdentifier) for 
LABEL= only if the currently used field is empty.

    Karel


-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2014-12-09 10:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 19:42 Fwd: Re: util-linux: libblkid: UDF superblock Pali Rohár
2014-12-05  2:09 ` Dale R. Worley
2014-12-05  2:25   ` Pali Rohár
2014-12-09 10:35     ` Karel Zak [this message]
2014-12-09 11:11       ` Pali Rohár
2014-12-09 21:08         ` Dale R. Worley
2014-12-19 13:56       ` Karel Zak
2014-12-19 15:55         ` Pali Rohár
2014-12-22 10:53         ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209103520.GK19904@x2.net.home \
    --to=kzak@redhat.com \
    --cc=pali.rohar@gmail.com \
    --cc=util-linux@vger.kernel.org \
    --cc=worley@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).