From: "Pali Rohár" <pali.rohar@gmail.com>
To: Karel Zak <kzak@redhat.com>
Cc: "Dale R. Worley" <worley@alum.mit.edu>, util-linux@vger.kernel.org
Subject: Re: Fwd: Re: util-linux: libblkid: UDF superblock
Date: Mon, 22 Dec 2014 11:53:18 +0100 [thread overview]
Message-ID: <201412221153.18431@pali> (raw)
In-Reply-To: <20141219135608.GN19904@x2.net.home>
[-- Attachment #1: Type: Text/Plain, Size: 1310 bytes --]
On Friday 19 December 2014 14:56:08 Karel Zak wrote:
> On Tue, Dec 09, 2014 at 11:35:20AM +0100, Karel Zak wrote:
> > > I looked into grub2 code and it is identifying UDF label
> > > also from LogicalVolumeIdentifier. So if you want to boot
> > > something from UDF FS via grub you probably see label
> > > problems...
> > >
> > > So I think that rather than using broken linux
> > > implementation is better to fix it (which could bring
> > > problems with different label names in new version). And
> > > I would like to see human readable label as "555e3160".
> >
> > It's more important to not introduce regression, if you have
> > LABEL= in your fstab then you don't want to see that after
> > util-linux update your setting is obsolete and filesystem
> > unmounted.
>
> You have convinced me that fix the problem (and improve
> compatibility) with UDF LABEL= is a good idea.
>
> Not sure, but I guess that for many users the change will be
> invisible because preferred way is to read the LABEL from
> ISO9660 header and UDF specific LABEL is just fallback
> solution only.
>
> The latest Pali's patches are at:
> https://github.com/karelzak/util-linux/pull/135
>
> Karel
Karel, can you review last version of my patch?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2014-12-22 10:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 19:42 Fwd: Re: util-linux: libblkid: UDF superblock Pali Rohár
2014-12-05 2:09 ` Dale R. Worley
2014-12-05 2:25 ` Pali Rohár
2014-12-09 10:35 ` Karel Zak
2014-12-09 11:11 ` Pali Rohár
2014-12-09 21:08 ` Dale R. Worley
2014-12-19 13:56 ` Karel Zak
2014-12-19 15:55 ` Pali Rohár
2014-12-22 10:53 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412221153.18431@pali \
--to=pali.rohar@gmail.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).