Util-Linux package development
 help / color / mirror / Atom feed
From: Peter Cordes <peter@cordes.ca>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH V3] docs: fix grammar and punctuation and typos in 2.26 release notes
Date: Mon, 19 Jan 2015 17:27:18 -0400	[thread overview]
Message-ID: <20150119212718.GZ29504@cordes.ca> (raw)
In-Reply-To: <1421701703-2129-1-git-send-email-bensberg@justemail.net>

On Mon, Jan 19, 2015 at 10:08:23PM +0100, Benno Schulenberg wrote:
> Also trim some trailing whitespace.
> 
> Reviewed-by: Peter Cordes <peter@cordes.ca>
> Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
> ---
>  Documentation/releases/v2.26-ReleaseNotes |   74 ++++++++++++++--------------
>  1 files changed, 37 insertions(+), 37 deletions(-)
> 
> diff --git a/Documentation/releases/v2.26-ReleaseNotes b/Documentation/releases/v2.26-ReleaseNotes
> index b7712f7..655aebe 100644
> --- a/Documentation/releases/v2.26-ReleaseNotes
> +++ b/Documentation/releases/v2.26-ReleaseNotes
> @@ -1,29 +1,29 @@
>  Util-linux 2.26 Release Notes
>  =============================
>  
> - This version provides completely new sfdisk(8) command, the new version is
> - based on libfdisk. If your use-cases depend on sfdisk(8) then it is strongly
> + This version provides a completely new sfdisk(8) command; the new version is
> + based on libfdisk. If your use cases depend on sfdisk(8), then it is strongly
>   recommended to be careful and re-test your scripts. The new version supports
> - MBR and GPT disk labels (SGI and SUN are also supported but no well tested).
> - The new version does no more support some obscure MBR specific command line
> - options and legacy CHS addressing.
> + MBR and GPT disk labels (SGI and SUN are also supported but not well tested).
> + The new version no longer supports some obscure MBR-specific command-line
> + options nor legacy CHS addressing.

 I think it's still not quite proper English, and might be worse.  I
think you might technically need an "either" to introduce the list, to
make "no longer supports" apply to "MBR opts or CHS addressing".  Like
a map operator.  But I'm not sure, and I don't want to take the time to
track it down.

 It doesn't really matter.  Leave it, or go back to "and", and people
will understand the "foreigner speak" if they notice a problem at all. :P

 Or change it to:

+ The new version drops support for some obscure MBR-specific command-line
+ options and legacy CHS addressing.

 I think that's fine without an "either" or a "both", but I can't
explain why.  Oh, the problems of knowing English without having been
formally taught all the grammar rules.  If I'd gone to school decades
earlier than I did, I'm sure I would have been taught all this stuff
formally. :P

-- 
#define X(x,y) x##y
Peter Cordes ;  e-mail: X(peter@cor , des.ca)

"The gods confound the man who first found out how to distinguish the hours!
 Confound him, too, who in this place set up a sundial, to cut and hack
 my day so wretchedly into small pieces!" -- Plautus, 200 BC

  reply	other threads:[~2015-01-19 21:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 19:09 [PATCH] docs: fix grammar and punctuation of 2.26 release notes Benno Schulenberg
2015-01-16  3:15 ` Peter Cordes
2015-01-17 17:56   ` Benno Schulenberg
2015-01-19 20:58     ` Peter Cordes
2015-01-18 20:46 ` [PATCH V2] docs: fix grammar and punctuation and typos in " Benno Schulenberg
2015-01-19 21:08 ` [PATCH V3] " Benno Schulenberg
2015-01-19 21:27   ` Peter Cordes [this message]
2015-01-26 10:18   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150119212718.GZ29504@cordes.ca \
    --to=peter@cordes.ca \
    --cc=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox