From: Karel Zak <kzak@redhat.com>
To: JWP <elseifthen@gmx.com>
Cc: Benno Schulenberg <bensberg@justemail.net>, util-linux@vger.kernel.org
Subject: Re: [PATCH] textual: fix spellos and inconsistencies in several program messages
Date: Mon, 26 Jan 2015 11:17:22 +0100 [thread overview]
Message-ID: <20150126101722.GC6354@x2.net.home> (raw)
In-Reply-To: <54BC1947.6060107@gmx.com>
On Sun, Jan 18, 2015 at 03:36:23PM -0500, JWP wrote:
> > - ui_warn(_("Cannot open: %s"), buf);
> > + ui_warn(_("Cannot open %s"), buf);
>
> > - ui_warn(_("Cannot open: %s"), buf);
> > + ui_warn(_("Cannot open %s"), buf);
>
> > - fdisk_warn(cxt, _("Cannot open: %s"), filename);
> > + fdisk_warn(cxt, _("Cannot open %s"), filename);
>
> > - fdisk_warn(cxt, _("Cannot open: %s"), filename);
> > + fdisk_warn(cxt, _("Cannot open %s"), filename);
>
> > - warn(_("cannot open: %s"), devname);
> > + warn(_("cannot open %s"), devname);
>
> > - warn(_("cannot open: %s"), dev);
> > + warn(_("cannot open %s"), dev);
>
> > - warn(_("cannot open: %s"), devname);
> > + warn(_("cannot open %s"), devname);
>
> > - "--map-root-user are mutually exclusive."));
> > + "--map-root-user are mutually exclusive"));
>
> > - log_warn(_("cannot open: %s: %m"), _PATH_OS_RELEASE);
> > + log_warn(_("cannot open %s: %m"), _PATH_OS_RELEASE);
>
> > - err(EXIT_FAILURE, _("cannot open: %s"), AGETTY_RELOAD_FILENAME);
> > + err(EXIT_FAILURE, _("cannot open %s"), AGETTY_RELOAD_FILENAME);
>
> Hey Benno, I thought we weren't allowed to make changes for punctuation only!
This is wanted and expected change, because "cannot open %s" is
already translated and used on many many place in code. The goal is
consolidation of the messages...
Karel
>
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-01-26 10:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 20:17 [PATCH] textual: fix spellos and inconsistencies in several program messages Benno Schulenberg
2015-01-18 20:22 ` Benno Schulenberg
2015-01-18 20:36 ` JWP
2015-01-26 10:17 ` Karel Zak [this message]
2015-01-26 10:19 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126101722.GC6354@x2.net.home \
--to=kzak@redhat.com \
--cc=bensberg@justemail.net \
--cc=elseifthen@gmx.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox