Util-Linux package development
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: Util-Linux <util-linux@vger.kernel.org>
Subject: Re: more nits in cfdisk
Date: Tue, 10 Feb 2015 13:20:26 +0100	[thread overview]
Message-ID: <20150210122026.GA11158@ws.net.home> (raw)
In-Reply-To: <1423426808.1949360.224667813.2ED36110@webmail.messagingengine.com>

On Sun, Feb 08, 2015 at 09:20:08PM +0100, Benno Schulenberg wrote:
> "Device does not contain a recognized partition table."
> This is most likely not an accurate message in this situation,
> so an upcoming patch suggests to differentiate between an
> invocation with --zero and a normal invocation.
> 
> A second patch will suggest to also accept a lowercase 'l'
> for loading a script file.  The Load command isn't dangerous,
> as is the Write command, so there is no need to make it
> somewhat more difficult to enter.

 Applied, thanks.

> When cfdisk prompts for a script file name, the line that says
> "Select a type..." should probably be cleared.  And maybe also
> the menu of label types?

 Improved.


> When the user enters a wrong name or some other error occurs,
> probably the line that says "The script file will be applied..."
> should be cleared.

 Improved.

> When starting cfdisk with --zero and choosing the sun label type,
> a bottombar message says: "Note that partition table entries are
> not in disk order now."  The menu item "Sort" is present, but
> using it has no effect.  Probably things have to be this way and
> the message shouldn't be given for a Sun label?

 Yes, fixed. (Note that Sun/SGI/BSD are not well tested with cfdisk.)


 I'm going to check/fix the rest from your list tomorrow. Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2015-02-10 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 20:20 more nits in cfdisk Benno Schulenberg
2015-02-10 12:20 ` Karel Zak [this message]
2015-02-19 11:02 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210122026.GA11158@ws.net.home \
    --to=kzak@redhat.com \
    --cc=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox