From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: Ruediger Meier <sweet_f_a@gmx.de>, util-linux@vger.kernel.org
Subject: Re: [PATCH] fsck: fix warning, gcc 5.0
Date: Mon, 16 Feb 2015 11:13:03 +0100 [thread overview]
Message-ID: <20150216101303.GG11948@ws.net.home> (raw)
In-Reply-To: <54E091A1.10404@bernhard-voelker.de>
On Sun, Feb 15, 2015 at 01:31:29PM +0100, Bernhard Voelker wrote:
> On 02/14/2015 07:12 PM, Ruediger Meier wrote:
> > - !strncmp(argv[i+1], "-", 1) == 0) {
> > + strncmp(argv[i+1], "-", 1) != 0) {
>
> ... or better avoid the strncmp() for 1 character at all?
Yes, fixed.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-02-16 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 18:12 [PATCH] fix warning, gcc 5.0 Ruediger Meier
2015-02-14 18:12 ` [PATCH] fsck: " Ruediger Meier
2015-02-15 12:31 ` Bernhard Voelker
2015-02-16 10:13 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216101303.GG11948@ws.net.home \
--to=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox