From: Karel Zak <kzak@redhat.com>
To: Phillip Susi <psusi@ubuntu.com>, util-linux <util-linux@vger.kernel.org>
Subject: Re: libsmartcols patch
Date: Mon, 16 Feb 2015 11:27:26 +0100 [thread overview]
Message-ID: <20150216102726.GH11948@ws.net.home> (raw)
In-Reply-To: <20150216050053.GA4075@vapier>
On Mon, Feb 16, 2015 at 12:00:53AM -0500, Mike Frysinger wrote:
> On 28 Dec 2014 20:30, Phillip Susi wrote:
> > --- libsmartcols/src/table_print.c 2014-12-24 23:59:55.780110296 +0200
> > +++ libsmartcols/src/table_print.c 2014-12-28 22:45:20.347285226 +0200
> >
> > + assert(ln);
> > + assert(buf);
>
> general note: libraries should never assert/abort/exit.
what about segfault?
We use assert to detect fatal internal library bugs, for mistakes in
applications (e.g. incomplete arguments) it returns -EINVAL.
Its' possible to remove CONFIG_LIBSMARTCOLS_ASSERT from smartcolsP.h,
but I don't think the library is already well tested.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-02-16 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 1:30 libsmartcols patch Phillip Susi
2015-01-07 14:26 ` Karel Zak
2015-02-16 5:00 ` Mike Frysinger
2015-02-16 10:27 ` Karel Zak [this message]
2015-02-16 10:48 ` Mike Frysinger
2015-02-16 13:46 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216102726.GH11948@ws.net.home \
--to=kzak@redhat.com \
--cc=psusi@ubuntu.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox