Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Subject: Re: prevent cal segfault
Date: Thu, 12 Mar 2015 10:10:49 +0100	[thread overview]
Message-ID: <201503121010.49968.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20150312084639.GC9756@laura.suse.cz>

On Thursday 12 March 2015, Petr Gajdos wrote:
> Hello,
>
> cal utility segfaults in putp() when setupterm() fails as cal
> insufficiently checks for setupterm() failure.
>
> $ TERM= cal
> Segmentation fault

Regarding TERM there is another issue with "more".

$ TERM= make check TS_OPTS="--parallel=1 more" 
  more: regexp                   ... FAILED (more/regexp)
  more: squeeze                  ... OK


Without TERM it prints a '\r' because of text-utils/more.c:1083:
void kill_line(void)
{
        erasep(0);
        if (!eraseln || dumb)
                putchar('\r');
}


cu,
Rudi

  reply	other threads:[~2015-03-12  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  8:46 prevent cal segfault Petr Gajdos
2015-03-12  9:10 ` Ruediger Meier [this message]
2015-03-12 11:05 ` Karel Zak
2015-03-12 12:00   ` Petr Gajdos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201503121010.49968.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox