From: Karel Zak <kzak@redhat.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org
Subject: Re: question about logger tests
Date: Fri, 27 Mar 2015 15:14:58 +0100 [thread overview]
Message-ID: <20150327141458.GN1749@ws.net.home> (raw)
In-Reply-To: <201503261450.33545.sweet_f_a@gmx.de>
On Thu, Mar 26, 2015 at 02:50:33PM +0100, Ruediger Meier wrote:
> Our logger tests fail if it can't connect to /dev/log. I'd like to fix
> that case for the test-suite but have some questions:
>
> 1. It was confusing for me to figure out the actual
> problem. Maybe --no-act and/or --stderr should imply
> that --socket-errors=auto turns error printing on?
Hmm.. probably good idea.
> 2. Alternatively we could use --socket-errors=on for all tests.
>
> 3. Couldn't we fix --no-act to not need an open /dev/log at all?
But then it will introduce another fragility, complexity and
difference between test (--no-act) and non-test mode. I see for
example "if(ctl->fd < 0)" in code. Now it really skips write() only.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-03-27 14:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 13:50 question about logger tests Ruediger Meier
2015-03-27 14:14 ` Karel Zak [this message]
2015-04-02 23:10 ` Ruediger Meier
2015-04-07 10:09 ` Karel Zak
2015-04-09 18:22 ` Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327141458.GN1749@ws.net.home \
--to=kzak@redhat.com \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox