Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Cc: Douglas Gilbert <dgilbert@interlog.com>
Subject: eject test fails with kernel 3.19
Date: Fri, 3 Apr 2015 15:19:38 +0100	[thread overview]
Message-ID: <201504031619.38548.sweet_f_a@gmx.de> (raw)

Hi,

eject(1) fails for scsi_debug module version 1.85 (kernel 3.19).

The Problem is that command ALLOW_MEDIUM_REMOVAL now returns 
driverstatus==DRIVER_SENSE with sensecode==0x20 (INVALID COMMAND 
OPERATION CODE).

If I ignore that senscode then the other two START_STOP commands finish 
successfully.

Should this be fixed in eject(1) or in scsi_debug or is it just a bad 
idea to eject scsi_debug devices? This documentations says 
ALLOW_MEDIUM_REMOVAL is supported.
http://sg.danny.cz/sg/sdebug.html

I guess the issue came with this kernel commit:

commit c2248fc974df7be55a5f6db6b6f99a90b749581b
Author: Douglas Gilbert <dgilbert@interlog.com>
Date:   Mon Nov 24 20:46:29 2014 -0500

    scsi_debug: change SCSI command parser to table driven

    The existing 'big switch' parser in queuecommand() is changed to
    a table driven parser. The old and new queuecommand() were moved
    in the source so diff would not shuffle them. Apart from the new
    tables most other changes are refactoring existing response code
    to be more easily called out of the table parser. The 'strict'
    parameter is added so that cdb_s can be checked for non-zero
    values in parts of the cdb that are reserved. Some other changes
    include: tweak request sense response when D_SENSE differs; support
    NDOB in Write Same(16); and fix crash in Get LBA Status when LBP
    was inactive.

cu,
Rudi

             reply	other threads:[~2015-04-03 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 14:19 Ruediger Meier [this message]
2015-04-03 16:38 ` eject test fails with kernel 3.19 Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504031619.38548.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=dgilbert@interlog.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox