From: Karel Zak <kzak@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 3/3] fsck: drop hardcoded search path
Date: Mon, 13 Apr 2015 12:27:05 +0200 [thread overview]
Message-ID: <20150413102705.GN3923@ws.net.home> (raw)
In-Reply-To: <1428829613-30423-3-git-send-email-vapier@gentoo.org>
On Sun, Apr 12, 2015 at 05:06:53AM -0400, Mike Frysinger wrote:
> We also drop the hardcoded minimal list of filesystem types that we
> "really want" to check. Instead, we blindly execute the fsck.<type>
> program whenever it's been requested.
This change makes fsck.<type> required for all filesystem, so it
breaks boot on many systems... Now fsck.<type> is optional for many
fs types (e.g. btrfs, xfs, ...).
> @@ -888,18 +838,8 @@ static int fsck_device(struct libmnt_fs *fs, int interactive)
> else
> type = DEFAULT_FSTYPE;
>
> - sprintf(progname, "fsck.%s", type);
> - progpath = find_fsck(progname);
> - if (progpath == NULL) {
> - if (fs_check_required(type)) {
> - retval = ENOENT;
> - goto err;
> - }
> - return 0;
> - }
This is important detail.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-04-13 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 9:06 [PATCH 1/3] mkfs: drop hardcoded search path Mike Frysinger
2015-04-12 9:06 ` [PATCH 2/3] swapon: search for mkswap via PATH Mike Frysinger
2015-04-27 8:59 ` Karel Zak
2015-04-12 9:06 ` [PATCH 3/3] fsck: drop hardcoded search path Mike Frysinger
2015-04-13 10:27 ` Karel Zak [this message]
2015-04-27 9:03 ` Karel Zak
2015-04-27 8:58 ` [PATCH 1/3] mkfs: " Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413102705.GN3923@ws.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox