From: Karel Zak <kzak@redhat.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH v2 0/7] logger tests do not need /dev/log but socat
Date: Tue, 14 Apr 2015 12:04:38 +0200 [thread overview]
Message-ID: <20150414100438.GV3923@ws.net.home> (raw)
In-Reply-To: <1428926513-25449-1-git-send-email-sweet_f_a@gmx.de>
On Mon, Apr 13, 2015 at 02:01:46PM +0200, Ruediger Meier wrote:
> Now we require socat for logger tests. We should NOT add fallback to
> netcat-like tools. I have tried this but there are too many different
> and broken netcat versions out there.
I think dependence on socat in the tests is fine, it's unnecessary to
have fallbacks for everything. It's test suite (mostly for developers)
not just some random environment on some random system.
> Ruediger Meier (7):
> logger: --stderr and --no-act turn "auto-errors" on
> tests: simplify common logger options
> tests: logger with socat device
> tests: logger, validate written socket data
> tests: logger/errors does not use --no-act
> tests: add subtests for invalid logger devive
> travis: install socat
Applied, thanks! It's perfect that we really test sockets now
(--stderr --no-act is poor man solution:-).
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-04-14 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 12:01 [PATCH v2 0/7] logger tests do not need /dev/log but socat Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 1/7] logger: --stderr and --no-act turn "auto-errors" on Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 2/7] tests: simplify common logger options Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 3/7] tests: logger with socat device Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 4/7] tests: logger, validate written socket data Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 5/7] tests: logger/errors does not use --no-act Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 6/7] tests: add subtests for invalid logger devive Ruediger Meier
2015-04-13 12:01 ` [PATCH v2 7/7] travis: install socat Ruediger Meier
2015-04-14 10:04 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150414100438.GV3923@ws.net.home \
--to=kzak@redhat.com \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox