Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: util-linux@vger.kernel.org
Cc: Federico Simoncelli <fsimonce@redhat.com>
Subject: blkdiscard progress breakes test
Date: Wed, 22 Apr 2015 19:43:06 +0200	[thread overview]
Message-ID: <201504221943.06644.sweet_f_a@gmx.de> (raw)

Hi,

Commit c472a7e3 introduced progress messages. This randomly
breaks the test-suite like this:


   blkdiscard: offsets                        ... FAILED (blkdiscard/offsets)
....
--- /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/expected/blkdiscard/offsets   2014-10-28 06:53:35.483698330 +0000
+++ /home/abuild/rpmbuild/BUILD/util-linux-2.26.git233.01aa/tests/output/blkdiscard/offsets     2015-04-22 15:41:45.748155291 +0000
@@ -21,7 +21,8 @@
 blkdiscard: offset 1 is not aligned to sector size 512
 blkdiscard: offset 1 is not aligned to sector size 512
 blkdiscard: offset 511 is not aligned to sector size 512
-Discarded 1536 bytes from the offset 512
+Discarded 1024 bytes from the offset 512
+Discarded 512 bytes from the offset 1536
 Discarded 1024 bytes from the offset 1024
 testing misaligned steps full device
 blkdiscard: length 1 is not aligned to sector size 512


It's because we ignore timeval's tv_usec here:
  if (last.tv_sec < now.tv_sec) {
      print_stats(path, stats);

We could make it better if we also compare tv_usec but IMO it would be fine
to print the stats only one time at the end. Maybe
 -v   prints stats one time only
 -vv  report progress


cu,
Rudi

             reply	other threads:[~2015-04-22 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 17:43 Ruediger Meier [this message]
2015-04-24 13:21 ` blkdiscard progress breakes test Federico Simoncelli
2015-04-27  8:24 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504221943.06644.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=fsimonce@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox