From: Karel Zak <kzak@redhat.com>
To: Michael Marineau <michael.marineau@coreos.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] libfdisk: (gpt) fix check for beginning of protective partition
Date: Tue, 5 May 2015 13:03:31 +0200 [thread overview]
Message-ID: <20150505110331.GF27969@ws.net.home> (raw)
In-Reply-To: <1430541873-27791-1-git-send-email-michael.marineau@coreos.com>
On Fri, May 01, 2015 at 09:44:33PM -0700, Michael Marineau wrote:
> Search for the protective partition before attempting to validate that
> it covers the GPT header. Some hybrid MBRs list partitions out of order.
> For example, CoreOS images ship with a hybrid MBR that lists the boot
> partition first and the protective partition second in order to maintain
> compatibility with old versions of Xen's PV-GRUB.
IMHO is better to say "sorry, this is unsupported use-case", than
really on bad thing like hybrid GPT.
Anyway applied, with your patch the code seems more robust, thanks.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-05-05 11:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 4:44 [PATCH] libfdisk: (gpt) fix check for beginning of protective partition Michael Marineau
2015-05-05 11:03 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505110331.GF27969@ws.net.home \
--to=kzak@redhat.com \
--cc=michael.marineau@coreos.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox