From: Karel Zak <kzak@redhat.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org,
Michael Marineau <michael.marineau@coreos.com>
Subject: Re: [PATCH] libfdisk: (gpt) fix attributes endianess
Date: Wed, 13 May 2015 11:17:00 +0200 [thread overview]
Message-ID: <20150513091700.GC4834@ws.net.home> (raw)
In-Reply-To: <201505120847.40612.sweet_f_a@gmx.de>
On Tue, May 12, 2015 at 08:47:40AM +0200, Ruediger Meier wrote:
> On Monday 11 May 2015, Karel Zak wrote:
> > On Fri, May 08, 2015 at 01:39:53PM +0200, Ruediger Meier wrote:
> > > The new libfdisk/gpt test (4a4a0927) discovered that we read and
> > > write partition attributes wrongly on BE systems.
> >
> > It was pretty hidden bug (as the problem was in the both set/get
> > functions).
>
> BTW maybe we could add the new raw attributes interface to sfdisk too.
> Like
> $ ./sfdisk --part-attrs img 1 "0x0000000000000001"
> (and also for stdin text input)
>
> This would make sfdisk forward compatible (in case they invent new
> attributes) and we could remove test_fdisk_gpt helper again.
Send patch :-)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-05-13 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 11:39 [PATCH] libfdisk: (gpt) fix attributes endianess Ruediger Meier
2015-05-08 13:44 ` Ruediger Meier
2015-05-11 10:25 ` Karel Zak
2015-05-12 6:47 ` Ruediger Meier
2015-05-13 9:17 ` Karel Zak [this message]
2015-05-13 9:58 ` Ruediger Meier
2015-05-13 11:16 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513091700.GC4834@ws.net.home \
--to=kzak@redhat.com \
--cc=michael.marineau@coreos.com \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox