Util-Linux package development
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Karel Zak <kzak@redhat.com>
Cc: WANG Chao <wcwxyz@gmail.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] lscpu: add cpu flags entry to summary output
Date: Fri, 15 May 2015 14:40:42 +0200	[thread overview]
Message-ID: <20150515124042.GC4280@osiris> (raw)
In-Reply-To: <20150515105402.GI4834@ws.net.home>

On Fri, May 15, 2015 at 12:54:02PM +0200, Karel Zak wrote:
> On Fri, May 15, 2015 at 09:37:48AM +0200, Heiko Carstens wrote:
> > On Wed, May 13, 2015 at 11:32:07AM +0200, Karel Zak wrote:
> > > On Wed, May 13, 2015 at 11:15:05AM +0800, WANG Chao wrote:
> > > >  sys-utils/lscpu.c | 3 +++
> > > >  1 file changed, 3 insertions(+)
> > > 
> > >  Applied, thanks.
> > 
> > Hello Karel,
> > 
> > just a general question, from my understanding the the summary output
> > is supposed to be human readable. I'm not sure how a 500+ character
> > line fits into this.
> 
> It's last line printed by lscpu, so terminal wraps it and from my
> point of view it's still pretty human readable.
> 
> > At least it doesn't fit to the current layout of the summary output,
> > but maybe that's just my impression.
> 
> Any suggestion how to improve it?
> 
> I think that provide incomplete info and force people to read also
> /proc/cpuinfo is bad idea.

Ok, I was just wondering what the general "guide line" for stuff like
this is.
When I applied the patch and saw the output it looked strange to me
and it didn't fit to the rest of the output. However that's probably
just my personal taste ;)

Anyway, no further objections.


      reply	other threads:[~2015-05-15 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  3:15 [PATCH] lscpu: add cpu flags entry to summary output WANG Chao
2015-05-13  9:32 ` Karel Zak
2015-05-15  7:37   ` Heiko Carstens
2015-05-15 10:54     ` Karel Zak
2015-05-15 12:40       ` Heiko Carstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150515124042.GC4280@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    --cc=wcwxyz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox