From: Karel Zak <kzak@redhat.com>
To: Stanislav Brabec <sbrabec@suse.cz>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Fix /dev to /sys node name translation
Date: Thu, 28 May 2015 12:40:05 +0200 [thread overview]
Message-ID: <20150528104005.GB7285@ws.net.home> (raw)
In-Reply-To: <5565C2A8.1070505@suse.cz>
On Wed, May 27, 2015 at 03:12:08PM +0200, Stanislav Brabec wrote:
> include/sysfs.h | 20 +++++++++++++++++++-
> lib/sysfs.c | 8 ++++++--
> 2 files changed, 25 insertions(+), 3 deletions(-)
Applied, thanks.
> static inline void sysfs_devname_to_dev_name (char *name)
> +static inline void sysfs_dev_name_to_devname (char *name)
but I have renamed to
sysfs_devname_sys_to_dev()
sysfs_devname_dev_to_sys()
because the original names have been too tricky :-)
I have also changed some thing in sysfs.c, it would be nice if we can
keep the crazy sysfs devnames (with '!') really only in sysfs specific
code and externally provide regular device names.
Please, test it -- especially lsblk.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-05-28 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 13:12 [PATCH] Fix /dev to /sys node name translation Stanislav Brabec
2015-05-28 10:40 ` Karel Zak [this message]
2015-05-28 13:02 ` Stanislav Brabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528104005.GB7285@ws.net.home \
--to=kzak@redhat.com \
--cc=sbrabec@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox