From: Karel Zak <kzak@redhat.com>
To: Romain Bouvier <skunnyk@alteroot.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Return correct value for uuid_generate_time_safe
Date: Thu, 18 Jun 2015 12:22:05 +0200 [thread overview]
Message-ID: <20150618102205.GD1992@ws.net.home> (raw)
In-Reply-To: <361341ee5502b6112bc452c27c15ea9f@webmail.alteroot.org>
On Wed, Jun 17, 2015 at 03:59:18PM +0000, Romain Bouvier wrote:
> Make return value consistent for consecutive calls.
> If you call uuid_generate_time_safe, it should always
> return -1 if it can't guarantee uniqueness.
> Without this patch, on consecutive calls where it can't guarantee
> uniqueness, the first call returns -1, but later calls return 0.
>
> Reported-by: Romain Bouvier <skunnyk@alteroot.org>
> Signed-off-by: Andreas Henriksson <andreas@fatal.se>
>
> ---
> libuuid/src/gen_uuid.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-06-18 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 15:59 [PATCH] Return correct value for uuid_generate_time_safe Romain Bouvier
2015-06-18 10:22 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618102205.GD1992@ws.net.home \
--to=kzak@redhat.com \
--cc=skunnyk@alteroot.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox