Util-Linux package development
 help / color / mirror / Atom feed
From: Andreas Henriksson <andreas@fatal.se>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] rename: allow full-path renames
Date: Mon, 22 Jun 2015 19:29:28 +0200	[thread overview]
Message-ID: <20150622172928.GA20786@fatal.se> (raw)
In-Reply-To: <CAG27Bk353ASGr0hyDe4oQvAZ3Swf_HbgonENtkOPFE_qcjE7MQ@mail.gmail.com>

Hello Sami Kerola.

On Mon, Jun 22, 2015 at 06:08:53PM +0100, Sami Kerola wrote:
> Hi Andreas,
> 
> Change looks good, but I would add a test to avoid same regression
> happening in future.  The same change with test can be found from
> my git.

Thanks for your quick review. I was just about to send out the tests
I was writing which should now be in your inbox with hopefully a bit
more coverage...

Also submitted patch v2 with your Reviewed-by added.

Regards,
Andreas Henriksson
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in

  parent reply	other threads:[~2015-06-22 17:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 16:23 [PATCH] rename: allow full-path renames Andreas Henriksson
2015-06-22 17:08 ` Sami Kerola
2015-06-22 17:22   ` [PATCH] tests: add fullpath tests to rename/subdir Andreas Henriksson
2015-06-25 10:03     ` Karel Zak
2015-06-22 17:26   ` [PATCH v2] rename: allow full-path renames Andreas Henriksson
2015-06-25 10:04     ` Karel Zak
2015-06-22 17:29   ` Andreas Henriksson [this message]
2015-06-25 10:06   ` [PATCH] " Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150622172928.GA20786@fatal.se \
    --to=andreas@fatal.se \
    --cc=kerolasa@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox