From: Karel Zak <kzak@redhat.com>
To: Stef Walter <stefw@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] agetty: Reprompt once the network addresses change if address displayed
Date: Mon, 20 Jul 2015 11:26:37 +0200 [thread overview]
Message-ID: <20150720092637.GF11633@ws.net.home> (raw)
In-Reply-To: <559E20A9.7010307@redhat.com>
On Thu, Jul 09, 2015 at 09:20:09AM +0200, Stef Walter wrote:
> I'm only a sporadic contributor to util-linux. I felt that adding a
> dependency to util-linux wasn't my place to suggest. In addition this
> patch performs very very simple usage of the netlink socket. We don't
> even look at message data.
IMHO it's fine.
> Fixed all of these other review items and pushed the patch here:
>
> https://github.com/stefwalter/util-linux/commits/agetty-addrchange
Applied, thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-07-20 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 12:58 [PATCH] agetty: Reprompt once the network addresses change if address displayed Stef Walter
2015-07-06 14:07 ` Mike Frysinger
2015-07-06 18:58 ` Bruce Dubbs
2015-07-07 4:25 ` Mike Frysinger
2015-07-07 5:05 ` Bruce Dubbs
2015-07-07 7:07 ` Mike Frysinger
2015-07-07 14:56 ` Bruce Dubbs
2015-07-07 15:56 ` Mike Frysinger
2015-07-09 7:20 ` Stef Walter
2015-07-20 9:26 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720092637.GF11633@ws.net.home \
--to=kzak@redhat.com \
--cc=stefw@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox