From: Karel Zak <kzak@redhat.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: Joel Holdsworth <joel.holdsworth@vcatechnology.com>,
util-linux@vger.kernel.org,
Joel Holdsworth <joel@airwebreathe.org.uk>
Subject: Re: [PATCH] build-sys: cal requires both ncurses and tinfo
Date: Fri, 24 Jul 2015 09:56:12 +0200 [thread overview]
Message-ID: <20150724075612.GE3432@ws.net.home> (raw)
In-Reply-To: <55B1D9F7.4040109@bernhard-voelker.de>
On Fri, Jul 24, 2015 at 08:23:51AM +0200, Bernhard Voelker wrote:
> On 07/24/2015 12:56 AM, Joel Holdsworth wrote:
> > This fixes a bug in the build system when building without ncurses
> > and tinfo. When cal is linked, it depends on both these libraries
> > and will fail to link if either of them is not available.
> >
> > This patch resolves the issue by explicitly declaring these
> > dependencies in the confgure.ac.
>
> wouldn't this invalidate configure's --without-ncurses option?
No, from this point of view the patch is correct
UL_BUILD_INIT([cal], [check])
specifies the util as optional, so
UL_REQUIRES_HAVE([cal], [ncurses], [ncurses library])
checks for the library and if not found then print WARNING and disable
the util.
UL_BUILD_INIT([cal], [yes])
specifies that the util is strictly required.
Anyway from my point of view the patch is unnecessary as cal.c should
be possible to compile without curses and tinfo at all.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-07-24 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 22:56 [PATCH] build-sys: cal requires both ncurses and tinfo Joel Holdsworth
2015-07-24 6:23 ` Bernhard Voelker
2015-07-24 7:56 ` Karel Zak [this message]
2015-07-24 17:33 ` Joel Holdsworth
2015-07-24 20:09 ` Karel Zak
2015-07-27 9:55 ` Karel Zak
2015-07-24 7:51 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724075612.GE3432@ws.net.home \
--to=kzak@redhat.com \
--cc=joel.holdsworth@vcatechnology.com \
--cc=joel@airwebreathe.org.uk \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox