From: Karel Zak <kzak@redhat.com>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 2/2] tests: add fsck.minix checks
Date: Mon, 3 Aug 2015 12:51:52 +0200 [thread overview]
Message-ID: <20150803105152.GG2619@ws.net.home> (raw)
In-Reply-To: <1438540140-959-2-git-send-email-kerolasa@iki.fi>
On Sun, Aug 02, 2015 at 07:29:00PM +0100, Sami Kerola wrote:
> tests/expected/minix/fsck-images-auto-fix | 31 ++++++++++++
> tests/expected/minix/fsck-images-broken-root | 7 +++
> tests/expected/minix/fsck-images-bug.773892 | 1 +
> tests/expected/minix/fsck-images-check-blocks | 9 ++++
> tests/expected/minix/fsck-images-v1c14 | 9 ++++
> tests/expected/minix/fsck-images-v1c30 | 9 ++++
> tests/expected/minix/fsck-images-v2c14 | 9 ++++
> tests/expected/minix/fsck-images-v2c30 | 9 ++++
> tests/expected/minix/fsck-images-v3c60 | 9 ++++
> tests/ts/minix/broken-root | Bin 0 -> 5120 bytes
> tests/ts/minix/debian.bug.773892 | Bin 0 -> 16384 bytes
> tests/ts/minix/fsck-images | 67 ++++++++++++++++++++++++++
Applied, thanks.
> +ts_check_test_command "$TS_CMD_FSCKMINIX"
> +ts_check_test_command "$TS_HELPER_MKFS_MINIX"
> +
> +export MKFS_MINIX_TEST_SECOND_SINCE_EPOCH='1438460212'
You forgot that the filesystem inodes also contains UID and GIT and
mkfs.minix uses getuid()... so the final checksum depends on used
account :-)
Fixed, I have updated the checksums and enabled the tests for root
(UID=0) only.
> +check_minix_fs_type() {
> + ts_init_subtest $1
> + dd if=/dev/zero bs=1024 count=16 of=$TS_OUTDIR/$1 >/dev/null 2>&1
$TS_OUTDIR/$1 is outside subtest namespace, fixed to use ${TS_OUTPUT}.img
> +echo "42" > $TS_OUTDIR/badlist
> +check_minix_fs_type 'check-blocks' "-l $TS_OUTDIR/badlist -c"
> +rm -f $TS_OUTDIR/badlist
same here. Fixed.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2015-08-03 10:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 18:28 [PATCH 1/2] tests: add way to control mkfs.minix time stamps Sami Kerola
2015-08-02 18:29 ` [PATCH 2/2] tests: add fsck.minix checks Sami Kerola
2015-08-03 10:51 ` Karel Zak [this message]
2015-08-07 7:20 ` Ruediger Meier
2015-08-03 10:38 ` [PATCH 1/2] tests: add way to control mkfs.minix time stamps Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803105152.GG2619@ws.net.home \
--to=kzak@redhat.com \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox