From: Karel Zak <kzak@redhat.com>
To: Werner Fink <werner@suse.de>, util-linux@vger.kernel.org
Subject: sulogin usemask
Date: Wed, 30 Sep 2015 14:46:38 +0200 [thread overview]
Message-ID: <20150930124638.GE1787@ws.net.home> (raw)
Hi,
https://github.com/systemd/systemd/pull/1399 this discussion
highlights that the code around 'usemask' is not robust enough.
The 'volatile' does not mean atomic.
It would be nice to improve the code -- avoid the mask at all, or use
pthread_mutex_lock() (note that you can use mmaped shared memory for
the muttex and share the lock between forked processes, you don't
have to use threads).
Comments?
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next reply other threads:[~2015-09-30 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 12:46 Karel Zak [this message]
2016-02-10 15:59 ` sulogin usemask Dr. Werner Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930124638.GE1787@ws.net.home \
--to=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox