From: Karel Zak <kzak@redhat.com>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, util-linux@vger.kernel.org
Subject: Re: [PATCH] script: don't assume time_t is compatible with long
Date: Fri, 16 Oct 2015 12:10:21 +0200 [thread overview]
Message-ID: <20151016101021.GC2990@ws.net.home> (raw)
In-Reply-To: <20151016011258.GA3711@newbook>
On Thu, Oct 15, 2015 at 06:12:59PM -0700, Isaac Dunham wrote:
> I'm guessing that the attached patch would be the most corrrect approach;
> any comments?
Applied,
> + if (!str || sscanf(str, "%lld", &sec) != 1)
Try compile with -Wformat, compiler does not like
%ll for int64_t types :-)
We usually use %jd and %ju for 64-bit numbers, but real pedantic
solution is to use SCN macros ("%"SCNi64 in this case) from
inttypes.h.
Hmm.. is there any system where intmax_t is already 128-bits? I know
that gcc already supports __int128_t on some archs, but it's not
treated as extended integer types. So, I guess we're relative safe
when we assume that intmax_t is 64-bits :-)
http://stackoverflow.com/questions/29927562/what-abi-if-any-restricts-the-size-of-uintmax-t
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-10-16 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 13:06 [PATCH] script: don't assume time_t is compatible with long Andreas Schwab
2015-10-16 1:12 ` Isaac Dunham
2015-10-16 10:10 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016101021.GC2990@ws.net.home \
--to=kzak@redhat.com \
--cc=ibid.ag@gmail.com \
--cc=schwab@suse.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox