From: Karel Zak <kzak@redhat.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: libblkid: blkid_bufinfo() fails on 32bit
Date: Thu, 3 Dec 2015 12:27:28 +0100 [thread overview]
Message-ID: <20151203112728.GK4955@ws.net.home> (raw)
In-Reply-To: <201512030257.06753.sweet_f_a@gmx.de>
On Thu, Dec 03, 2015 at 02:57:06AM +0100, Ruediger Meier wrote:
> but it still looks broken, see this debug output
>
>
> libblkid: LOWPROBE: --> starting probing loop [SUBLKS idx=-1]
> libblkid: LOWPROBE: [0] linux_raid_member:
> libblkid: LOWPROBE: call probefunc()
> libblkid: BUFFER: mapping end of the device
> libblkid: BUFFER: mmap 0xf7321000: off=4112515072, len=25771900928 (6291968 pages)
> ^^^^^^^
Yep, fixed.
-#define PROBE_ALIGN_OFF(p, o) ((o) & ~((p)->mmap_granularity - 1))
+#define PROBE_ALIGN_OFF(p, o) ((o) & ~((p)->mmap_granularity - 1ULL))
.. it's necessary to be more explicit with constants ;-)
Thanks!
Karel
> shouldn't we only mmap about 2M?
>
> libblkid: BUFFER: reuse 0xf7321000: off=4112515072 len=25771900928 (for off=29884407808 len=256)
> libblkid: BUFFER: mapping begin of the device
> libblkid: BUFFER: mmap 0xf7121000: off=0, len=2097152 (512 pages)
> libblkid: BUFFER: reuse 0xf7121000: off=0 len=2097152 (for off=4096 len=256)
>
> cu,
> Rudi
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2015-12-03 11:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 1:57 libblkid: blkid_bufinfo() fails on 32bit Ruediger Meier
2015-12-03 11:27 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203112728.GK4955@ws.net.home \
--to=kzak@redhat.com \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox