From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: sfdisk, re-eading partition table fails
Date: Fri, 18 Dec 2015 15:32:17 +0100 [thread overview]
Message-ID: <201512181532.18097.sweet_f_a@gmx.de> (raw)
In-Reply-To: <201512151326.33633.sweet_f_a@gmx.de>
On Tuesday 15 December 2015, Ruediger Meier wrote:
> On Tuesday 15 December 2015, Karel Zak wrote:
> > On Mon, Dec 14, 2015 at 01:11:59PM +0100, Ruediger Meier wrote:
> > > Removing the first BLKRRPART ioctl (or sleeping about 50ms after
> > > the first one) "fixes" the issue.
> >
> > The is_device_used() in the sfdisk is nothing elegant,
>
> But how else could we check whether a device is in use?
>
> > maybe
> > we can use --noreread sfdisk command line option in the tests.
>
> I have such patch already for testing.
It's now on github pull request #244 among other patches
https://github.com/karelzak/util-linux/pull/244
Would be still nice to fix the problem within sfdisk somehow.
BTW I found that is_device_used() is not called for other generic
options like --reorder. This seems inconsistent.
cu,
Rudi
prev parent reply other threads:[~2015-12-18 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 12:11 sfdisk, re-eading partition table fails Ruediger Meier
2015-12-15 10:24 ` Karel Zak
2015-12-15 12:26 ` Ruediger Meier
2015-12-15 13:33 ` Karel Zak
2015-12-18 14:32 ` Ruediger Meier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201512181532.18097.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox