From: "Rüdiger Meier" <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: Bernhard Voelker <mail@bernhard-voelker.de>, util-linux@vger.kernel.org
Subject: Re: sfdisk, stderr/stdout output order
Date: Thu, 10 Mar 2016 15:35:43 +0100 [thread overview]
Message-ID: <201603101535.43195.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20160310142450.rqx2yfah5waotnag@ws.net.home>
On Thursday 10 March 2016 15:24:50 Karel Zak wrote:
> On Thu, Mar 10, 2016 at 03:08:28PM +0100, Bernhard Voelker wrote:
> > On 03/10/2016 12:16 PM, Karel Zak wrote:
> > >On Thu, Mar 10, 2016 at 11:40:50AM +0100, R=FCdiger Meier wrote:
> > >>I've found such test diffs with musl libc. Maybe it needs some
> > >> fflush(3) calls.
> > >
> > > Yes, good point. I'll fix it.
> >
> > I don't think you can enforce stdout/stderr to be synchronous.
> > Well, you can try with "stdbuf(1)", but only having coreutils >v7.5
> > (2009). Why not check the output of both streams separately?
>
> Well, it's not about tests (although check both streams separately
> will be improvement). The problem is that we write to stderr and=20
> stdout in fdisks, fflush(stdout) before warnings will make things
> more deterministic.
Yep, I had found more problems like in rename below. For rename we
should probably fix the test rather than adding fflush().
=2D-- /home/rudi/devel/util-linux/tests/expected/rename/exit_codes
+++ /tmp/build-musl/tests/output/rename/exit_codes=20
@@ -2,6 +2,6 @@
`rename_exit_codes.1' -> `rename_exit_values.1'
`rename_exit_codes.2' -> `rename_exit_values.2'
EXIT_SUCCESS: 0
=2Drename: rename_exit_values.2: rename to rename_exit_codes.2 failed: Is a=
directory
`rename_exit_values.1' -> `rename_exit_codes.1'
+rename: rename_exit_values.2: rename to rename_exit_codes.2 failed: Is a d=
irectory
RENAME_EXIT_SOMEOK: 2
cu,
Rudi
prev parent reply other threads:[~2016-03-10 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 10:40 sfdisk, stderr/stdout output order Rüdiger Meier
2016-03-10 11:16 ` Karel Zak
2016-03-10 14:08 ` Bernhard Voelker
2016-03-10 14:24 ` Karel Zak
2016-03-10 14:35 ` Rüdiger Meier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603101535.43195.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=kzak@redhat.com \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox