From: Ruediger Meier <sweet_f_a@gmx.de>
To: Isaac Dunham <ibid.ag@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 00/12] another BSD/OSX related patch-set
Date: Mon, 14 Mar 2016 02:43:40 +0100 [thread overview]
Message-ID: <201603140243.40546.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20160308012836.GA26455@newbook>
On Tuesday 08 March 2016, Isaac Dunham wrote:
> On Tue, Mar 08, 2016 at 12:11:50AM +0100, Ruediger Meier wrote:
> > From: Ruediger Meier <ruediger.meier@ga-group.nl>
> >
> > This is github pull request #299
> > https://github.com/karelzak/util-linux/pull/299
> >
> > Again some arbitrary BSD, OSX and musl related fixes and clean-up
>
> <snip>
>
> > For OSX one should additionally disable all utmp.h related
> > programs.
>
> FYI:
> With musl, utmpx is stubbed out and utmp is wrappers for utmpx, so
> users should disable utmp(x)-related programs and code.
> (The point is to let things build, but not use utmp because the
> maintainer considers it a fundamentally flawed idea.)
>
> Additionally, systemd is working on allowing disabling of utmp(x).
Will there be another interface to be used by last(1)?
> This seems to imply that --disable-utmp/--disable-utmpx options would
> be helpful.
Do you mean --without-utmp to build our progs without utmp or really
disabling the build of all progs which are using utmp right now?
Actually I thought the next step could be to remove utmp and use utmpx
only because it's POSIX and more portable. See commit d00c10ed.
> > Almost no interesting compiler warnings left. Xcode/clang warnings
> > are a bit over the top anyways.
> >
> >
> > Ruediger Meier (12):
> > wipefs, sfdisk: include libgen.h for basename(3p)
>
> I'm glad to see use of POSIX basename(), which is the only version
> that musl implements.
There are still two files to be fixed
login-utils/last.c
login-utils/su-common.c
On the other hand I thought we could also completely avoid basename(3p)
and use something like our stripoff_last_component() from
lib/fileutils.c.
> The way musl implements basename, strdup() is not needed, but
> following POSIX is better than relying on implementation-specific
> details.
>
> Thanks,
> Isaac Dunham
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-14 1:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 23:11 [PATCH 00/12] another BSD/OSX related patch-set Ruediger Meier
2016-03-07 23:11 ` [PATCH 01/12] wipefs, sfdisk: include libgen.h for basename(3p) Ruediger Meier
2016-03-07 23:11 ` [PATCH 02/12] misc: again fixing many printf format strings Ruediger Meier
2016-03-07 23:11 ` [PATCH 03/12] lib: include sys/stat.h for struct stat Ruediger Meier
2016-03-07 23:11 ` [PATCH 04/12] fdisk: sun, undef HAVE_QSORT_R for non-Linux Ruediger Meier
2016-03-07 23:11 ` [PATCH 05/12] libfdisk: remove ifdef HDIO_GETGEO Ruediger Meier
2016-03-07 23:11 ` [PATCH 06/12] misc: never cast void* from malloc(3) and friends Ruediger Meier
2016-03-07 23:11 ` [PATCH 07/12] libmount: don't include libio.h Ruediger Meier
2016-03-07 23:11 ` [PATCH 08/12] tests: cramfs, fix root group Ruediger Meier
2016-03-07 23:11 ` [PATCH 09/12] tests: don't skip case "output undefined" Ruediger Meier
2016-03-07 23:12 ` [PATCH 10/12] tests: getopt2, add function gnu_getopt_clean() Ruediger Meier
2016-03-07 23:12 ` [PATCH 11/12] tests: improve getopt loop error case Ruediger Meier
2016-03-07 23:12 ` [PATCH 12/12] getopt: fix -n name for BSD Ruediger Meier
2016-03-08 1:28 ` [PATCH 00/12] another BSD/OSX related patch-set Isaac Dunham
2016-03-14 1:43 ` Ruediger Meier [this message]
2016-03-14 15:10 ` Karel Zak
2016-03-15 2:10 ` Isaac Dunham
2016-03-15 11:24 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603140243.40546.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=ibid.ag@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox