Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: Sami Kerola <kerolasa@iki.fi>, util-linux@vger.kernel.org
Subject: Re: [PATCH 1/3] chrt: make --sched-* short options to require an argument
Date: Mon, 4 Apr 2016 10:07:11 +0100	[thread overview]
Message-ID: <201604041107.12672.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20160404082749.tqyzkgyba2ed77kr@ws.net.home>

On Monday 04 April 2016, Karel Zak wrote:
> On Mon, Apr 04, 2016 at 02:21:00AM +0200, Karel Zak wrote:
> > On Sun, Apr 03, 2016 at 09:35:27AM +0100, Sami Kerola wrote:
> > > These options are expecting an argument, and the long options
> > > struct already required them.
> >
> >  Good catch, but deadline and runtime should be optional arguments
> > (it seems I have merged wrong version of my patch:-(
>
> Sorry, didn't read the patch correctly. You're right. Applied,
> thanks.

BTW I like the coreutils convention that new options with optional 
arguments should be long options only. This is less confusing for the 
users.

cu,
Rudi

  reply	other threads:[~2016-04-04  9:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03  8:35 [PATCH 0/3] pull: chrt fixes Sami Kerola
2016-04-03  8:35 ` [PATCH 1/3] chrt: make --sched-* short options to require an argument Sami Kerola
2016-04-04  0:21   ` Karel Zak
2016-04-04  8:27     ` Karel Zak
2016-04-04  9:07       ` Ruediger Meier [this message]
2016-04-04 14:43         ` Sami Kerola
2016-04-14 10:32           ` Karel Zak
2016-04-03  8:35 ` [PATCH 2/3] bash-completion: update chrt completion Sami Kerola
2016-04-04  8:29   ` Karel Zak
2016-04-03  8:35 ` [PATCH 3/3] chrt: validate priority before trying to use it Sami Kerola
2016-04-04  8:33   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604041107.12672.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=kerolasa@iki.fi \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox